Re: [PATCH v1] crypto: ccp: sp-pci: use generic power management

2020-07-21 Thread Vaibhav Gupta
On Tue, Jul 21, 2020 at 12:15:13PM -0500, Tom Lendacky wrote: > On 7/21/20 11:30 AM, Vaibhav Gupta wrote: > > On Tue, Jul 21, 2020 at 10:19:33AM -0500, Tom Lendacky wrote: > >> On 7/21/20 7:31 AM, Vaibhav Gupta wrote: > >>> +bool __maybe_unused ccp_queues_suspended(struct ccp_device *ccp) > >> > >>

Re: [PATCH v1] crypto: ccp: sp-pci: use generic power management

2020-07-21 Thread Tom Lendacky
On 7/21/20 11:30 AM, Vaibhav Gupta wrote: > On Tue, Jul 21, 2020 at 10:19:33AM -0500, Tom Lendacky wrote: >> On 7/21/20 7:31 AM, Vaibhav Gupta wrote: >>> Drivers using legacy power management .suspen()/.resume() callbacks >>> have to manage PCI states and device's PM states themselves. They also >>

Re: [PATCH v1] crypto: ccp: sp-pci: use generic power management

2020-07-21 Thread Vaibhav Gupta
On Tue, Jul 21, 2020 at 10:19:33AM -0500, Tom Lendacky wrote: > On 7/21/20 7:31 AM, Vaibhav Gupta wrote: > > Drivers using legacy power management .suspen()/.resume() callbacks > > have to manage PCI states and device's PM states themselves. They also > > need to take care of standard configuration

Re: [PATCH v1] crypto: ccp: sp-pci: use generic power management

2020-07-21 Thread Tom Lendacky
On 7/21/20 7:31 AM, Vaibhav Gupta wrote: > Drivers using legacy power management .suspen()/.resume() callbacks > have to manage PCI states and device's PM states themselves. They also > need to take care of standard configuration registers. > > Switch to generic power management framework using a

Re: [PATCH v1] crypto: ccp: sp-pci: use generic power management

2020-07-21 Thread Vaibhav Gupta
The Patch is Compile-tested only.

[PATCH v1] crypto: ccp: sp-pci: use generic power management

2020-07-21 Thread Vaibhav Gupta
Drivers using legacy power management .suspen()/.resume() callbacks have to manage PCI states and device's PM states themselves. They also need to take care of standard configuration registers. Switch to generic power management framework using a single "struct dev_pm_ops" variable to take the unn