Quoting Al Viro :
On Thu, Oct 25, 2012 at 08:38:25PM -0700, Linus Torvalds wrote:
It's valid to cast a non-const pointer to a const one. It's the
*other* way around that is invalid.
So marking fw_path[] as having 'const char *' elements just means that
we won't be changing those elements thro
On Thu, Oct 25, 2012 at 08:38:25PM -0700, Linus Torvalds wrote:
> It's valid to cast a non-const pointer to a const one. It's the
> *other* way around that is invalid.
>
> So marking fw_path[] as having 'const char *' elements just means that
> we won't be changing those elements through the fw_p
On Thu, Oct 25, 2012 at 8:12 PM, Ming Lei wrote:
>
> Yes, it should be the cleanest, I don't do it because I thought that might
> have caused one compile warning('const char *' points to memory
> without 'const', like below)
You can just keep the const.
In fact, you could even add one, and make
On Fri, Oct 26, 2012 at 10:32 AM, Linus Torvalds
wrote:
>
> Please just make "fw_path[0]" just be the pointer to fw_path_para[]
> (which sounds like the cleanest fix) and get rid of the negative 'i'
> and conditional entirely.
Yes, it should be the cleanest, I don't do it because I thought that m
On Thu, Oct 25, 2012 at 5:46 PM, Ming Lei wrote:
> struct file *file;
> - snprintf(path, PATH_MAX, "%s/%s", fw_path[i], buf->fw_id);
> +
> + if (i < 0) {
> + if (!fw_path_para[0]) /* No customized path */
> +
This patch introduces one module parameter of 'path' in firmware_class
to support customizing firmware image search path, so that people can
use its own firmware path if the default built-in paths can't meet their
demand[1], and the typical usage is passing the below from kernel command
parameter w
6 matches
Mail list logo
