On 1/21/19 10:23 AM, Christoph Hellwig wrote:
> On Mon, Jan 21, 2019 at 10:19:15AM -0600, Dave Kleikamp wrote:
>> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
>> index 65d8fc87ab11..c15ff56a8516 100644
>> --- a/fs/jfs/super.c
>> +++ b/fs/jfs/super.c
>> @@ -174,9 +174,11 @@ static int jfs_statfs(str
On Mon, Jan 21, 2019 at 10:19:15AM -0600, Dave Kleikamp wrote:
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index 65d8fc87ab11..c15ff56a8516 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -174,9 +174,11 @@ static int jfs_statfs(struct dentry *dentry, struct
> kstatfs *buf)
> b
On 1/21/19 2:49 AM, Christoph Hellwig wrote:
>> +buf->f_fsid.val[1] = (u32)crc32_le(0, (char *)&sbi->uuid +
>> sizeof(sbi->uuid)/2,
>
> This adds an overly long line, and has weird operator spacing.
>
> In fact given how much deep magic it does it should probably be moved
> into a helper and
> + buf->f_fsid.val[1] = (u32)crc32_le(0, (char *)&sbi->uuid +
> sizeof(sbi->uuid)/2,
This adds an overly long line, and has weird operator spacing.
In fact given how much deep magic it does it should probably be moved
into a helper and properly documented when you touch it anyway.
On 1/10/19 7:41 AM, Andy Shevchenko wrote:
> There are new types and helpers that are supposed to be used in new code.
>
> As a preparation to get rid of legacy types and API functions do
> the conversion here.
Looks good to me. I tweaked it slightly to keep checkpatch from
complaining about line
There are new types and helpers that are supposed to be used in new code.
As a preparation to get rid of legacy types and API functions do
the conversion here.
Signed-off-by: Andy Shevchenko
---
- not tested on real FS
fs/jfs/jfs_incore.h | 6 --
fs/jfs/jfs_logmgr.c | 17
6 matches
Mail list logo
