Re: [PATCH v1] i2c: tegra: Fix i2c_writesl() to use writel() instead of writesl()

2021-01-12 Thread Sowjanya Komatineni
On 1/12/21 1:32 AM, David Laight wrote: From: Sowjanya Komatineni Sent: 11 January 2021 17:38 ... Using writesl() for filling TX_FIFO causing silent hang immediate on any i2c register access after filling FIFO with 8 words and some times with 6 words as well. So couldn't INTERRUPT_STATUS re

RE: [PATCH v1] i2c: tegra: Fix i2c_writesl() to use writel() instead of writesl()

2021-01-12 Thread David Laight
From: Sowjanya Komatineni > Sent: 11 January 2021 17:38 ... > Using writesl() for filling TX_FIFO causing silent hang immediate on any > i2c register access after filling FIFO with 8 words and some times with > 6 words as well. > > So couldn't INTERRUPT_STATUS registers to check for TX FIFO Overfl

Re: [PATCH v1] i2c: tegra: Fix i2c_writesl() to use writel() instead of writesl()

2021-01-11 Thread Sowjanya Komatineni
On 1/11/21 11:29 AM, Dmitry Osipenko wrote: 11.01.2021 20:38, Sowjanya Komatineni пишет: On 1/11/21 4:09 AM, Dmitry Osipenko wrote: 11.01.2021 14:50, Dmitry Osipenko пишет: 20.10.2020 19:37, Sowjanya Komatineni пишет: On 10/20/20 12:48 AM, Thierry Reding wrote: On Mon, Oct 19, 2020 at 09:0

Re: [PATCH v1] i2c: tegra: Fix i2c_writesl() to use writel() instead of writesl()

2021-01-11 Thread Dmitry Osipenko
11.01.2021 20:38, Sowjanya Komatineni пишет: > > On 1/11/21 4:09 AM, Dmitry Osipenko wrote: >> 11.01.2021 14:50, Dmitry Osipenko пишет: >>> 20.10.2020 19:37, Sowjanya Komatineni пишет: On 10/20/20 12:48 AM, Thierry Reding wrote: > On Mon, Oct 19, 2020 at 09:03:54PM -0700, Sowjanya Komatin

Re: [PATCH v1] i2c: tegra: Fix i2c_writesl() to use writel() instead of writesl()

2021-01-11 Thread Sowjanya Komatineni
On 1/11/21 4:09 AM, Dmitry Osipenko wrote: 11.01.2021 14:50, Dmitry Osipenko пишет: 20.10.2020 19:37, Sowjanya Komatineni пишет: On 10/20/20 12:48 AM, Thierry Reding wrote: On Mon, Oct 19, 2020 at 09:03:54PM -0700, Sowjanya Komatineni wrote: VI I2C don't have DMA support and uses PIO mode a

Re: [PATCH v1] i2c: tegra: Fix i2c_writesl() to use writel() instead of writesl()

2021-01-11 Thread Dmitry Osipenko
11.01.2021 14:50, Dmitry Osipenko пишет: > 20.10.2020 19:37, Sowjanya Komatineni пишет: >> >> On 10/20/20 12:48 AM, Thierry Reding wrote: >>> On Mon, Oct 19, 2020 at 09:03:54PM -0700, Sowjanya Komatineni wrote: VI I2C don't have DMA support and uses PIO mode all the time. Current dri

Re: [PATCH v1] i2c: tegra: Fix i2c_writesl() to use writel() instead of writesl()

2021-01-11 Thread Dmitry Osipenko
20.10.2020 19:37, Sowjanya Komatineni пишет: > > On 10/20/20 12:48 AM, Thierry Reding wrote: >> On Mon, Oct 19, 2020 at 09:03:54PM -0700, Sowjanya Komatineni wrote: >>> VI I2C don't have DMA support and uses PIO mode all the time. >>> >>> Current driver uses writesl() to fill TX FIFO based on avai

Re: [PATCH v1] i2c: tegra: Fix i2c_writesl() to use writel() instead of writesl()

2021-01-11 Thread Thierry Reding
On Mon, Oct 19, 2020 at 09:03:54PM -0700, Sowjanya Komatineni wrote: > VI I2C don't have DMA support and uses PIO mode all the time. > > Current driver uses writesl() to fill TX FIFO based on available > empty slots and with this seeing strange silent hang during any I2C > register access after fi

Re: [PATCH v1] i2c: tegra: Fix i2c_writesl() to use writel() instead of writesl()

2020-10-20 Thread Sowjanya Komatineni
On 10/20/20 9:37 AM, Sowjanya Komatineni wrote: On 10/20/20 12:48 AM, Thierry Reding wrote: On Mon, Oct 19, 2020 at 09:03:54PM -0700, Sowjanya Komatineni wrote: VI I2C don't have DMA support and uses PIO mode all the time. Current driver uses writesl() to fill TX FIFO based on available emp

Re: [PATCH v1] i2c: tegra: Fix i2c_writesl() to use writel() instead of writesl()

2020-10-20 Thread Sowjanya Komatineni
On 10/20/20 12:48 AM, Thierry Reding wrote: On Mon, Oct 19, 2020 at 09:03:54PM -0700, Sowjanya Komatineni wrote: VI I2C don't have DMA support and uses PIO mode all the time. Current driver uses writesl() to fill TX FIFO based on available empty slots and with this seeing strange silent hang

Re: [PATCH v1] i2c: tegra: Fix i2c_writesl() to use writel() instead of writesl()

2020-10-20 Thread Thierry Reding
On Mon, Oct 19, 2020 at 09:03:54PM -0700, Sowjanya Komatineni wrote: > VI I2C don't have DMA support and uses PIO mode all the time. > > Current driver uses writesl() to fill TX FIFO based on available > empty slots and with this seeing strange silent hang during any I2C > register access after fi

[PATCH v1] i2c: tegra: Fix i2c_writesl() to use writel() instead of writesl()

2020-10-19 Thread Sowjanya Komatineni
VI I2C don't have DMA support and uses PIO mode all the time. Current driver uses writesl() to fill TX FIFO based on available empty slots and with this seeing strange silent hang during any I2C register access after filling TX FIFO with 8 words. Using writel() followed by i2c_readl() in a loop t