Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-10-17 Thread Dmitry Osipenko
On 10/17/18 10:41 PM, Jon Hunter wrote: > > On 17/10/2018 15:30, Dmitry Osipenko wrote: >> On 10/17/18 4:59 PM, Jon Hunter wrote: >>> >>> On 13/05/2018 22:13, Dmitry Osipenko wrote: Nothing prevents I2C clients to access I2C while Tegra's driver is being suspended, this results in

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-10-17 Thread Dmitry Osipenko
On 10/17/18 10:41 PM, Jon Hunter wrote: > > On 17/10/2018 15:30, Dmitry Osipenko wrote: >> On 10/17/18 4:59 PM, Jon Hunter wrote: >>> >>> On 13/05/2018 22:13, Dmitry Osipenko wrote: Nothing prevents I2C clients to access I2C while Tegra's driver is being suspended, this results in

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-10-17 Thread Jon Hunter
On 17/10/2018 15:30, Dmitry Osipenko wrote: > On 10/17/18 4:59 PM, Jon Hunter wrote: >> >> On 13/05/2018 22:13, Dmitry Osipenko wrote: >>> Nothing prevents I2C clients to access I2C while Tegra's driver is being >>> suspended, this results in -EBUSY error returned to the clients and that >>> may

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-10-17 Thread Jon Hunter
On 17/10/2018 15:30, Dmitry Osipenko wrote: > On 10/17/18 4:59 PM, Jon Hunter wrote: >> >> On 13/05/2018 22:13, Dmitry Osipenko wrote: >>> Nothing prevents I2C clients to access I2C while Tegra's driver is being >>> suspended, this results in -EBUSY error returned to the clients and that >>> may

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-10-17 Thread Dmitry Osipenko
On 10/17/18 4:59 PM, Jon Hunter wrote: > > On 13/05/2018 22:13, Dmitry Osipenko wrote: >> Nothing prevents I2C clients to access I2C while Tegra's driver is being >> suspended, this results in -EBUSY error returned to the clients and that >> may have unfortunate consequences. In particular this

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-10-17 Thread Dmitry Osipenko
On 10/17/18 4:59 PM, Jon Hunter wrote: > > On 13/05/2018 22:13, Dmitry Osipenko wrote: >> Nothing prevents I2C clients to access I2C while Tegra's driver is being >> suspended, this results in -EBUSY error returned to the clients and that >> may have unfortunate consequences. In particular this

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-10-17 Thread Jon Hunter
On 13/05/2018 22:13, Dmitry Osipenko wrote: > Nothing prevents I2C clients to access I2C while Tegra's driver is being > suspended, this results in -EBUSY error returned to the clients and that > may have unfortunate consequences. In particular this causes problems > for the TPS6586x MFD driver

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-10-17 Thread Jon Hunter
On 13/05/2018 22:13, Dmitry Osipenko wrote: > Nothing prevents I2C clients to access I2C while Tegra's driver is being > suspended, this results in -EBUSY error returned to the clients and that > may have unfortunate consequences. In particular this causes problems > for the TPS6586x MFD driver

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-30 Thread Dmitry Osipenko
On 30.05.2018 23:25, Wolfram Sang wrote: > >> Applied to for-next, thanks! > > I removed the stable tag, though. I am not 100% sure if there are not > any side-effects for other users. If you still think it should go to > stable, please mention this patch to stable@ after it was applied to >

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-30 Thread Dmitry Osipenko
On 30.05.2018 23:25, Wolfram Sang wrote: > >> Applied to for-next, thanks! > > I removed the stable tag, though. I am not 100% sure if there are not > any side-effects for other users. If you still think it should go to > stable, please mention this patch to stable@ after it was applied to >

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-30 Thread Wolfram Sang
> Applied to for-next, thanks! I removed the stable tag, though. I am not 100% sure if there are not any side-effects for other users. If you still think it should go to stable, please mention this patch to stable@ after it was applied to linus tree. Maybe with a word or two about regression

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-30 Thread Wolfram Sang
> Applied to for-next, thanks! I removed the stable tag, though. I am not 100% sure if there are not any side-effects for other users. If you still think it should go to stable, please mention this patch to stable@ after it was applied to linus tree. Maybe with a word or two about regression

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-30 Thread Wolfram Sang
On Mon, May 14, 2018 at 12:13:47AM +0300, Dmitry Osipenko wrote: > Nothing prevents I2C clients to access I2C while Tegra's driver is being > suspended, this results in -EBUSY error returned to the clients and that > may have unfortunate consequences. In particular this causes problems > for the

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-30 Thread Wolfram Sang
On Mon, May 14, 2018 at 12:13:47AM +0300, Dmitry Osipenko wrote: > Nothing prevents I2C clients to access I2C while Tegra's driver is being > suspended, this results in -EBUSY error returned to the clients and that > may have unfortunate consequences. In particular this causes problems > for the

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-30 Thread Laxman Dewangan
On Tuesday 29 May 2018 11:36 PM, Wolfram Sang wrote: Our I2C driver is based on the interrupt. So we have converted the suspend/resume to suspend_noirq and reseume_noirq so that we will not allow the transfer when system interrupt disabled in downstream.

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-30 Thread Laxman Dewangan
On Tuesday 29 May 2018 11:36 PM, Wolfram Sang wrote: Our I2C driver is based on the interrupt. So we have converted the suspend/resume to suspend_noirq and reseume_noirq so that we will not allow the transfer when system interrupt disabled in downstream.

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-29 Thread Wolfram Sang
> > Our I2C driver is based on the interrupt. So we have converted the > > suspend/resume to suspend_noirq and reseume_noirq so that we will not allow > > the > > transfer when system interrupt disabled in downstream. > >   SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(tegra_i2c_suspend,

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-29 Thread Wolfram Sang
> > Our I2C driver is based on the interrupt. So we have converted the > > suspend/resume to suspend_noirq and reseume_noirq so that we will not allow > > the > > transfer when system interrupt disabled in downstream. > >   SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(tegra_i2c_suspend,

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-14 Thread Dmitry Osipenko
On 14.05.2018 15:18, Wolfram Sang wrote: > On Mon, May 14, 2018 at 01:59:33PM +0200, Thierry Reding wrote: >> On Mon, May 14, 2018 at 12:13:47AM +0300, Dmitry Osipenko wrote: >>> Nothing prevents I2C clients to access I2C while Tegra's driver is being >>> suspended, this results in -EBUSY error

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-14 Thread Dmitry Osipenko
On 14.05.2018 15:18, Wolfram Sang wrote: > On Mon, May 14, 2018 at 01:59:33PM +0200, Thierry Reding wrote: >> On Mon, May 14, 2018 at 12:13:47AM +0300, Dmitry Osipenko wrote: >>> Nothing prevents I2C clients to access I2C while Tegra's driver is being >>> suspended, this results in -EBUSY error

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-14 Thread Dmitry Osipenko
On 14.05.2018 15:21, Laxman Dewangan wrote: > > > On Monday 14 May 2018 05:29 PM, Thierry Reding wrote: >> * PGP Signed by an unknown key >> >> On Mon, May 14, 2018 at 12:13:47AM +0300, Dmitry Osipenko wrote: >>> Nothing prevents I2C clients to access I2C while Tegra's driver is being >>>

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-14 Thread Dmitry Osipenko
On 14.05.2018 15:21, Laxman Dewangan wrote: > > > On Monday 14 May 2018 05:29 PM, Thierry Reding wrote: >> * PGP Signed by an unknown key >> >> On Mon, May 14, 2018 at 12:13:47AM +0300, Dmitry Osipenko wrote: >>> Nothing prevents I2C clients to access I2C while Tegra's driver is being >>>

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-14 Thread Thierry Reding
On Mon, May 14, 2018 at 05:51:58PM +0530, Laxman Dewangan wrote: > > > On Monday 14 May 2018 05:29 PM, Thierry Reding wrote: > > * PGP Signed by an unknown key > > > > On Mon, May 14, 2018 at 12:13:47AM +0300, Dmitry Osipenko wrote: > > > Nothing prevents I2C clients to access I2C while Tegra's

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-14 Thread Thierry Reding
On Mon, May 14, 2018 at 05:51:58PM +0530, Laxman Dewangan wrote: > > > On Monday 14 May 2018 05:29 PM, Thierry Reding wrote: > > * PGP Signed by an unknown key > > > > On Mon, May 14, 2018 at 12:13:47AM +0300, Dmitry Osipenko wrote: > > > Nothing prevents I2C clients to access I2C while Tegra's

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-14 Thread Laxman Dewangan
On Monday 14 May 2018 05:29 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Mon, May 14, 2018 at 12:13:47AM +0300, Dmitry Osipenko wrote: Nothing prevents I2C clients to access I2C while Tegra's driver is being suspended, this results in -EBUSY error returned to the clients and

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-14 Thread Laxman Dewangan
On Monday 14 May 2018 05:29 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Mon, May 14, 2018 at 12:13:47AM +0300, Dmitry Osipenko wrote: Nothing prevents I2C clients to access I2C while Tegra's driver is being suspended, this results in -EBUSY error returned to the clients and

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-14 Thread Wolfram Sang
On Mon, May 14, 2018 at 01:59:33PM +0200, Thierry Reding wrote: > On Mon, May 14, 2018 at 12:13:47AM +0300, Dmitry Osipenko wrote: > > Nothing prevents I2C clients to access I2C while Tegra's driver is being > > suspended, this results in -EBUSY error returned to the clients and that > > may have

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-14 Thread Wolfram Sang
On Mon, May 14, 2018 at 01:59:33PM +0200, Thierry Reding wrote: > On Mon, May 14, 2018 at 12:13:47AM +0300, Dmitry Osipenko wrote: > > Nothing prevents I2C clients to access I2C while Tegra's driver is being > > suspended, this results in -EBUSY error returned to the clients and that > > may have

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-14 Thread Thierry Reding
On Mon, May 14, 2018 at 12:13:47AM +0300, Dmitry Osipenko wrote: > Nothing prevents I2C clients to access I2C while Tegra's driver is being > suspended, this results in -EBUSY error returned to the clients and that > may have unfortunate consequences. In particular this causes problems > for the

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-14 Thread Thierry Reding
On Mon, May 14, 2018 at 12:13:47AM +0300, Dmitry Osipenko wrote: > Nothing prevents I2C clients to access I2C while Tegra's driver is being > suspended, this results in -EBUSY error returned to the clients and that > may have unfortunate consequences. In particular this causes problems > for the

[PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-13 Thread Dmitry Osipenko
Nothing prevents I2C clients to access I2C while Tegra's driver is being suspended, this results in -EBUSY error returned to the clients and that may have unfortunate consequences. In particular this causes problems for the TPS6586x MFD driver which emits hundreds of "failed to read interrupt

[PATCH v1] i2c: tegra: Remove suspend-resume

2018-05-13 Thread Dmitry Osipenko
Nothing prevents I2C clients to access I2C while Tegra's driver is being suspended, this results in -EBUSY error returned to the clients and that may have unfortunate consequences. In particular this causes problems for the TPS6586x MFD driver which emits hundreds of "failed to read interrupt