Re: [PATCH v1] mm: thp: check pmd_trans_unstable() after split_huge_pmd()

2016-06-01 Thread Naoya Horiguchi
On Wed, Jun 01, 2016 at 12:39:57PM +0300, Kirill A. Shutemov wrote: > On Wed, Jun 01, 2016 at 09:36:40AM +0900, Naoya Horiguchi wrote: > > split_huge_pmd() doesn't guarantee that the pmd is normal pmd pointing to > > pte entries, which can be checked with pmd_trans_unstable(). > > Could you be mor

Re: [PATCH v1] mm: thp: check pmd_trans_unstable() after split_huge_pmd()

2016-06-01 Thread Kirill A. Shutemov
On Wed, Jun 01, 2016 at 09:36:40AM +0900, Naoya Horiguchi wrote: > split_huge_pmd() doesn't guarantee that the pmd is normal pmd pointing to > pte entries, which can be checked with pmd_trans_unstable(). Could you be more specific on when we don't have normal ptes after split_huge_pmd? Race with o

[PATCH v1] mm: thp: check pmd_trans_unstable() after split_huge_pmd()

2016-05-31 Thread Naoya Horiguchi
split_huge_pmd() doesn't guarantee that the pmd is normal pmd pointing to pte entries, which can be checked with pmd_trans_unstable(). Some callers of split_huge_pmd() don't have the check, so let's add it. Signed-off-by: Naoya Horiguchi --- mm/gup.c | 2 ++ mm/mempolicy.c | 2 ++ mm/mprot