Re: [PATCH v1] module: Fully remove the kernel_module_from_file hook

2016-08-01 Thread James Morris
On Sun, 31 Jul 2016, Mimi Zohar wrote: > On Do, 2016-07-28 at 11:30 -0700, Kees Cook wrote: > > On Tue, Jul 12, 2016 at 5:48 AM, James Morris wrote: > > > On Sat, 9 Jul 2016, Mickaël Salaün wrote: > > > > > >> Fixes: a1db74209483 ("module: replace copy_module_from_fd with kernel > > >> version")

Re: [PATCH v1] module: Fully remove the kernel_module_from_file hook

2016-07-31 Thread Mimi Zohar
On Do, 2016-07-28 at 11:30 -0700, Kees Cook wrote: > On Tue, Jul 12, 2016 at 5:48 AM, James Morris wrote: > > On Sat, 9 Jul 2016, Mickaël Salaün wrote: > > > >> Fixes: a1db74209483 ("module: replace copy_module_from_fd with kernel > >> version") > >> > >> Signed-off-by: Mickaël Salaün > >> Cc: M

Re: [PATCH v1] module: Fully remove the kernel_module_from_file hook

2016-07-28 Thread Kees Cook
On Tue, Jul 12, 2016 at 5:48 AM, James Morris wrote: > On Sat, 9 Jul 2016, Mickaël Salaün wrote: > >> Fixes: a1db74209483 ("module: replace copy_module_from_fd with kernel >> version") >> >> Signed-off-by: Mickaël Salaün >> Cc: Mimi Zohar >> Cc: Kees Cook >> Cc: Luis R. Rodriguez >> Cc: Rusty

Re: [PATCH v1] module: Fully remove the kernel_module_from_file hook

2016-07-12 Thread James Morris
On Sat, 9 Jul 2016, Mickaël Salaün wrote: > Fixes: a1db74209483 ("module: replace copy_module_from_fd with kernel > version") > > Signed-off-by: Mickaël Salaün > Cc: Mimi Zohar > Cc: Kees Cook > Cc: Luis R. Rodriguez > Cc: Rusty Russell > Cc: Linus Torvalds > Cc: Greg Kroah-Hartman Acke

Re: [PATCH v1] module: Fully remove the kernel_module_from_file hook

2016-07-11 Thread Greg Kroah-Hartman
On Sat, Jul 09, 2016 at 08:19:15PM +0200, Mickaël Salaün wrote: > Fixes: a1db74209483 ("module: replace copy_module_from_fd with kernel > version") It's not a "fix", it's a "cleanup remaining bits"

Re: [PATCH v1] module: Fully remove the kernel_module_from_file hook

2016-07-11 Thread Kees Cook
On Sat, Jul 9, 2016 at 2:19 PM, Mickaël Salaün wrote: > Fixes: a1db74209483 ("module: replace copy_module_from_fd with kernel > version") Oh, hrm, was that still in there? Thanks for the catch! Acked-by: Kees Cook -Kees > > Signed-off-by: Mickaël Salaün > Cc: Mimi Zohar > Cc: Kees Cook >

[PATCH v1] module: Fully remove the kernel_module_from_file hook

2016-07-09 Thread Mickaël Salaün
Fixes: a1db74209483 ("module: replace copy_module_from_fd with kernel version") Signed-off-by: Mickaël Salaün Cc: Mimi Zohar Cc: Kees Cook Cc: Luis R. Rodriguez Cc: Rusty Russell Cc: Linus Torvalds Cc: Greg Kroah-Hartman --- include/linux/lsm_hooks.h | 1 - include/linux/security.h | 1 -