Re: [PATCH v1] perf callchain: fix kernel symbol resolution by remembering the cpumode

2015-03-27 Thread David Hildenbrand
> > > > Commit 2e77784bb7d8 ("perf callchain: Move cpumode resolve code to > > add_callchain_ip") promised "No change in behavior.". > > > > As this commit breaks callchains on s390x (symbols not getting resolved, > > observed when profiling the kernel), this statement is wrong. The > > cpumode

RE: [PATCH v1] perf callchain: fix kernel symbol resolution by remembering the cpumode

2015-03-27 Thread Liang, Kan
> Commit 2e77784bb7d8 ("perf callchain: Move cpumode resolve code to > add_callchain_ip") promised "No change in behavior.". > > As this commit breaks callchains on s390x (symbols not getting resolved, > observed when profiling the kernel), this statement is wrong. The > cpumode must be kept whe

[PATCH v1] perf callchain: fix kernel symbol resolution by remembering the cpumode

2015-03-27 Thread David Hildenbrand
Commit 2e77784bb7d8 ("perf callchain: Move cpumode resolve code to add_callchain_ip") promised "No change in behavior.". As this commit breaks callchains on s390x (symbols not getting resolved, observed when profiling the kernel), this statement is wrong. The cpumode must be kept when iterating ov