Re: [PATCH v1] phy: qcom-qusb2: Fix HSTX_TRIM tuning with fused value for SDM845

2018-10-12 Thread Doug Anderson
Hi, On Thu, Oct 11, 2018 at 10:57 PM wrote: > Fused value is supposed to always override. If value is not fused for > some > parts (which I believe is case with some early samples), then driver > will > read it is '0' from nvmem and should use hstx-trim value passed from DT. OK cool. Just

Re: [PATCH v1] phy: qcom-qusb2: Fix HSTX_TRIM tuning with fused value for SDM845

2018-10-12 Thread Doug Anderson
Hi, On Thu, Oct 11, 2018 at 10:57 PM wrote: > Fused value is supposed to always override. If value is not fused for > some > parts (which I believe is case with some early samples), then driver > will > read it is '0' from nvmem and should use hstx-trim value passed from DT. OK cool. Just

Re: [PATCH v1] phy: qcom-qusb2: Fix HSTX_TRIM tuning with fused value for SDM845

2018-10-11 Thread mgautam
Hi, On 2018-10-11 04:06, Doug Anderson wrote: Hi, On Fri, Oct 5, 2018 at 2:09 AM Manu Gautam wrote: Tune1 register on sdm845 is used to update HSTX_TRIM with fused setting. Enable same by specifying update_tune1_with_efuse flag for sdm845, otherwise driver ends up programming tune2

Re: [PATCH v1] phy: qcom-qusb2: Fix HSTX_TRIM tuning with fused value for SDM845

2018-10-11 Thread mgautam
Hi, On 2018-10-11 04:06, Doug Anderson wrote: Hi, On Fri, Oct 5, 2018 at 2:09 AM Manu Gautam wrote: Tune1 register on sdm845 is used to update HSTX_TRIM with fused setting. Enable same by specifying update_tune1_with_efuse flag for sdm845, otherwise driver ends up programming tune2

Re: [PATCH v1] phy: qcom-qusb2: Fix HSTX_TRIM tuning with fused value for SDM845

2018-10-10 Thread Doug Anderson
Hi, On Fri, Oct 5, 2018 at 2:09 AM Manu Gautam wrote: > > Tune1 register on sdm845 is used to update HSTX_TRIM with fused > setting. Enable same by specifying update_tune1_with_efuse flag > for sdm845, otherwise driver ends up programming tune2 register. > While at it, also fix HSTX_TRIM tuning

Re: [PATCH v1] phy: qcom-qusb2: Fix HSTX_TRIM tuning with fused value for SDM845

2018-10-10 Thread Doug Anderson
Hi, On Fri, Oct 5, 2018 at 2:09 AM Manu Gautam wrote: > > Tune1 register on sdm845 is used to update HSTX_TRIM with fused > setting. Enable same by specifying update_tune1_with_efuse flag > for sdm845, otherwise driver ends up programming tune2 register. > While at it, also fix HSTX_TRIM tuning

[PATCH v1] phy: qcom-qusb2: Fix HSTX_TRIM tuning with fused value for SDM845

2018-10-05 Thread Manu Gautam
Tune1 register on sdm845 is used to update HSTX_TRIM with fused setting. Enable same by specifying update_tune1_with_efuse flag for sdm845, otherwise driver ends up programming tune2 register. While at it, also fix HSTX_TRIM tuning logic which instead of using fused value as HSTX_TRIM, incorrectly

[PATCH v1] phy: qcom-qusb2: Fix HSTX_TRIM tuning with fused value for SDM845

2018-10-05 Thread Manu Gautam
Tune1 register on sdm845 is used to update HSTX_TRIM with fused setting. Enable same by specifying update_tune1_with_efuse flag for sdm845, otherwise driver ends up programming tune2 register. While at it, also fix HSTX_TRIM tuning logic which instead of using fused value as HSTX_TRIM, incorrectly