Re: [PATCH v1] platform/x86: wmi: Replace kmalloc + sprintf() with kasprintf()

2018-02-16 Thread Darren Hart
On Fri, Feb 16, 2018 at 03:55:24PM +, David Laight wrote: > From: Andy Shevchenko > > Sent: 16 February 2018 15:40 > > > > kasprintf() does the job of two: kmalloc() and sprintf(). > > Replace two calls with one. > ... > > - buf = kmalloc(strlen(wdriver->driver.name) + 5, GFP_KERNEL);

Re: [PATCH v1] platform/x86: wmi: Replace kmalloc + sprintf() with kasprintf()

2018-02-16 Thread Andy Shevchenko
On Fri, Feb 16, 2018 at 5:55 PM, David Laight wrote: >> kasprintf() does the job of two: kmalloc() and sprintf(). >> Replace two calls with one. > ... >> - buf = kmalloc(strlen(wdriver->driver.name) + 5, GFP_KERNEL); >> + buf = kasprintf(GFP_KERNEL, "wmi/%s", wdriver->driv

RE: [PATCH v1] platform/x86: wmi: Replace kmalloc + sprintf() with kasprintf()

2018-02-16 Thread David Laight
From: Andy Shevchenko > Sent: 16 February 2018 15:40 > > kasprintf() does the job of two: kmalloc() and sprintf(). > Replace two calls with one. ... > - buf = kmalloc(strlen(wdriver->driver.name) + 5, GFP_KERNEL); > + buf = kasprintf(GFP_KERNEL, "wmi/%s", wdriver->driver.nam

[PATCH v1] platform/x86: wmi: Replace kmalloc + sprintf() with kasprintf()

2018-02-16 Thread Andy Shevchenko
kasprintf() does the job of two: kmalloc() and sprintf(). Replace two calls with one. Signed-off-by: Andy Shevchenko --- drivers/platform/x86/wmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index c0c8945603cb..4e