Re: [PATCH v1] sched/cfs: Fix pick_next_entity() implementation error

thanks for your explanation. you are right. @lest should be used as reference point to compare. Please ignore this patch. On 7/1/2020 6:47 PM, Vincent Guittot wrote: > On Wed, 1 Jul 2020 at 12:07, Zijun Hu wrote: >> >> sched_entity @se not static @left should be compared >> to pick up @cfs_rq->ne

Re: [PATCH v1] sched/cfs: Fix pick_next_entity() implementation error

On Wed, 1 Jul 2020 at 12:07, Zijun Hu wrote: > > sched_entity @se not static @left should be compared > to pick up @cfs_rq->next. Could you elaborate why ? left is the leftmost sched_entity and the one that should be used. se != left means that left should be skipped after a yield and the next

[PATCH v1] sched/cfs: Fix pick_next_entity() implementation error

sched_entity @se not static @left should be compared to pick up @cfs_rq->next. Signed-off-by: Zijun Hu --- kernel/sched/fair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 658aa7a2ae6f..4790f2d851ad 100644 --- a/kernel/sc