Re: [PATCH v1] scsi: ufs: no need to send one Abort Task TM in case the task in DB was cleared

2020-08-10 Thread Stanley Chu
Hi Bean, On Mon, 2020-08-10 at 17:41 +0200, Bean Huo wrote: > On Thu, 2020-08-06 at 18:07 +0800, Can Guo wrote: > > Hi Bean, > > > > On 2020-08-06 17:50, Bean Huo wrote: > > > > > > > > Please check Stanley's recent change to ufshcd_abort, you may > > > > want to rebase your change on his and do

Re: [PATCH v1] scsi: ufs: no need to send one Abort Task TM in case the task in DB was cleared

2020-08-10 Thread Bean Huo
On Thu, 2020-08-06 at 18:07 +0800, Can Guo wrote: > Hi Bean, > > On 2020-08-06 17:50, Bean Huo wrote: > > > > > > Please check Stanley's recent change to ufshcd_abort, you may > > > want to rebase your change on his and do goto cleanup here. > > > @Stanley correct me if I am wrong. > > > > > > B

Re: [PATCH v1] scsi: ufs: no need to send one Abort Task TM in case the task in DB was cleared

2020-08-06 Thread Can Guo
Hi Bean, On 2020-08-06 17:50, Bean Huo wrote: Please check Stanley's recent change to ufshcd_abort, you may want to rebase your change on his and do goto cleanup here. @Stanley correct me if I am wrong. But even if you do a goto cleanup here, we still lost the chances to dump host infos/regs l

Re: [PATCH v1] scsi: ufs: no need to send one Abort Task TM in case the task in DB was cleared

2020-08-06 Thread Bean Huo
> > Please check Stanley's recent change to ufshcd_abort, you may > want to rebase your change on his and do goto cleanup here. > @Stanley correct me if I am wrong. > > But even if you do a goto cleanup here, we still lost the > chances to dump host infos/regs like it does in the old code. > If

Re: [PATCH v1] scsi: ufs: no need to send one Abort Task TM in case the task in DB was cleared

2020-08-06 Thread Can Guo
Hi Bean, On 2020-08-04 20:35, Bean Huo wrote: From: Bean Huo If the bit corresponds to a task in the Doorbell register has been cleared, no need to poll the status of the task on the device side and to send an Abort Task TM. This patch also deletes dispensable dev_err() in case of the task alr

[PATCH v1] scsi: ufs: no need to send one Abort Task TM in case the task in DB was cleared

2020-08-04 Thread Bean Huo
From: Bean Huo If the bit corresponds to a task in the Doorbell register has been cleared, no need to poll the status of the task on the device side and to send an Abort Task TM. This patch also deletes dispensable dev_err() in case of the task already completed. Signed-off-by: Bean Huo --- dr