Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management

2020-07-27 Thread Vaibhav Gupta
On Mon, Jul 27, 2020 at 02:12:16PM +0300, Andy Shevchenko wrote: > On Mon, Jul 27, 2020 at 10:08 AM Vaibhav Gupta > wrote: > > On Sat, Jul 25, 2020 at 01:44:44PM +0300, Andy Shevchenko wrote: > > > On Sat, Jul 25, 2020 at 1:42 PM Andy Shevchenko > > > wrote: > > ... > > > > The only problem he

Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management

2020-07-27 Thread Andy Shevchenko
On Mon, Jul 27, 2020 at 10:08 AM Vaibhav Gupta wrote: > On Sat, Jul 25, 2020 at 01:44:44PM +0300, Andy Shevchenko wrote: > > On Sat, Jul 25, 2020 at 1:42 PM Andy Shevchenko > > wrote: ... > > The only problem here, is that the 2nd is already in the Mark's tree > > and he doesn't do rebases. > >

Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management

2020-07-27 Thread Vaibhav Gupta
On Sat, Jul 25, 2020 at 01:44:44PM +0300, Andy Shevchenko wrote: > On Sat, Jul 25, 2020 at 1:42 PM Andy Shevchenko > wrote: > > On Sat, Jul 25, 2020 at 1:37 AM Bjorn Helgaas wrote: > > > On Fri, Jul 24, 2020 at 11:16:55PM +0300, Andy Shevchenko wrote: > > ... > > > > If it's a bug that spi-topc

Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management

2020-07-25 Thread Andy Shevchenko
On Sat, Jul 25, 2020 at 1:42 PM Andy Shevchenko wrote: > On Sat, Jul 25, 2020 at 1:37 AM Bjorn Helgaas wrote: > > On Fri, Jul 24, 2020 at 11:16:55PM +0300, Andy Shevchenko wrote: ... > > If it's a bug that spi-topcliff-pch.c disables but never enables > > wakeup, I think this should turn into t

Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management

2020-07-25 Thread Andy Shevchenko
On Sat, Jul 25, 2020 at 1:37 AM Bjorn Helgaas wrote: > > [+cc Rafael, in case you can clear up our wakeup confusion] > original patch: > https://lore.kernel.org/r/20200720155714.714114-1-vaibhavgupt...@gmail.com > > On Fri, Jul 24, 2020 at 11:16:55PM +0300, Andy Shevchenko wrote: > > On Fri, Jul 2

Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management

2020-07-24 Thread Bjorn Helgaas
[+cc Rafael, in case you can clear up our wakeup confusion] original patch: https://lore.kernel.org/r/20200720155714.714114-1-vaibhavgupt...@gmail.com On Fri, Jul 24, 2020 at 11:16:55PM +0300, Andy Shevchenko wrote: > On Fri, Jul 24, 2020 at 6:17 PM Vaibhav Gupta > wrote: > > On Fri, Jul 24, 202

Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management

2020-07-24 Thread Andy Shevchenko
On Fri, Jul 24, 2020 at 6:17 PM Vaibhav Gupta wrote: > On Fri, Jul 24, 2020 at 01:51:49PM +0300, Andy Shevchenko wrote: > > On Mon, Jul 20, 2020 at 7:31 PM Vaibhav Gupta > > wrote: ... > > > + device_wakeup_disable(dev); > > > > Here I left a result. Care to explain (and perhaps send a f

Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management

2020-07-24 Thread Vaibhav Gupta
On Fri, Jul 24, 2020 at 01:51:49PM +0300, Andy Shevchenko wrote: > On Mon, Jul 20, 2020 at 7:31 PM Vaibhav Gupta > wrote: > > > > Drivers using legacy PM have to manage PCI states and device's PM states > > themselves. They also need to take care of configuration registers. > > > > With improved

Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management

2020-07-24 Thread Andy Shevchenko
On Mon, Jul 20, 2020 at 7:31 PM Vaibhav Gupta wrote: > > Drivers using legacy PM have to manage PCI states and device's PM states > themselves. They also need to take care of configuration registers. > > With improved and powerful support of generic PM, PCI Core takes care of > above mentioned, de

Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management

2020-07-22 Thread Vaibhav Gupta
On Wed, Jul 22, 2020 at 02:45:17PM +0100, Mark Brown wrote: > On Mon, 20 Jul 2020 21:27:15 +0530, Vaibhav Gupta wrote: > > Drivers using legacy PM have to manage PCI states and device's PM states > > themselves. They also need to take care of configuration registers. > > > > With improved and powe

Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management

2020-07-22 Thread Mark Brown
On Mon, 20 Jul 2020 21:27:15 +0530, Vaibhav Gupta wrote: > Drivers using legacy PM have to manage PCI states and device's PM states > themselves. They also need to take care of configuration registers. > > With improved and powerful support of generic PM, PCI Core takes care of > above mentioned,

[PATCH v1] spi: spi-topcliff-pch: use generic power management

2020-07-20 Thread Vaibhav Gupta
Drivers using legacy PM have to manage PCI states and device's PM states themselves. They also need to take care of configuration registers. With improved and powerful support of generic PM, PCI Core takes care of above mentioned, device-independent, jobs. This driver makes use of PCI helper func