Re: [PATCH v1 02/10] mm: remove SWAP_DIRTY in ttu

2017-03-14 Thread Minchan Kim
Hello Hillf, On Mon, Mar 13, 2017 at 02:34:37PM +0800, Hillf Danton wrote: > > On March 13, 2017 8:36 AM Minchan Kim wrote: > > > > If we found lazyfree page is dirty, try_to_unmap_one can just > > SetPageSwapBakced in there like PG_mlocked page and just return > > with SWAP_FAIL which is very

Re: [PATCH v1 02/10] mm: remove SWAP_DIRTY in ttu

2017-03-12 Thread Hillf Danton
On March 13, 2017 8:36 AM Minchan Kim wrote: > > If we found lazyfree page is dirty, try_to_unmap_one can just > SetPageSwapBakced in there like PG_mlocked page and just return > with SWAP_FAIL which is very natural because the page is not > swappable right now so that vmscan can activate it. >

[PATCH v1 02/10] mm: remove SWAP_DIRTY in ttu

2017-03-12 Thread Minchan Kim
If we found lazyfree page is dirty, try_to_unmap_one can just SetPageSwapBakced in there like PG_mlocked page and just return with SWAP_FAIL which is very natural because the page is not swappable right now so that vmscan can activate it. There is no point to introduce new return value SWAP_DIRTY i