Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-04-02 Thread Luis R. Rodriguez
On Thu, Apr 02, 2015 at 05:52:16PM -0600, Toshi Kani wrote: > On Thu, 2015-04-02 at 23:49 +0200, Luis R. Rodriguez wrote: > > On Sat, Mar 28, 2015 at 12:56:30AM +0100, Luis R. Rodriguez wrote: > > > On Fri, Mar 27, 2015 at 02:40:17PM -0600, Toshi Kani wrote: > > > > On Fri, 2015-03-20 at 16:17 -070

Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-04-02 Thread Toshi Kani
On Thu, 2015-04-02 at 23:49 +0200, Luis R. Rodriguez wrote: > On Sat, Mar 28, 2015 at 12:56:30AM +0100, Luis R. Rodriguez wrote: > > On Fri, Mar 27, 2015 at 02:40:17PM -0600, Toshi Kani wrote: > > > On Fri, 2015-03-20 at 16:17 -0700, Luis R. Rodriguez wrote: > > > : > > > > @@ -734,6 +742,7 @@ voi

Re: [Xen-devel] [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-04-02 Thread Luis R. Rodriguez
On Thu, Apr 2, 2015 at 3:09 PM, Bjorn Helgaas wrote: > On Thu, Apr 2, 2015 at 4:02 PM, Luis R. Rodriguez wrote: > >> --- >> It is possible to enable CONFIG_MTRR and CONFIG_X86_PAT >> and end up with a system with MTRR functionality disabled >> PAT functionality enabled. > > This is missing a conj

Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-04-02 Thread Bjorn Helgaas
On Thu, Apr 2, 2015 at 4:02 PM, Luis R. Rodriguez wrote: > --- > It is possible to enable CONFIG_MTRR and CONFIG_X86_PAT > and end up with a system with MTRR functionality disabled > PAT functionality enabled. This is missing a conjunction or something in "MTRR functionality disabled PAT functio

Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-04-02 Thread Luis R. Rodriguez
On Sat, Mar 28, 2015 at 12:56:30AM +0100, Luis R. Rodriguez wrote: > On Fri, Mar 27, 2015 at 02:40:17PM -0600, Toshi Kani wrote: > > On Fri, 2015-03-20 at 16:17 -0700, Luis R. Rodriguez wrote: > > : > > > @@ -734,6 +742,7 @@ void __init mtrr_bp_init(void) > > > } > > > > > > if (mtrr_if) { >

Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-04-02 Thread Luis R. Rodriguez
On Thu, Apr 02, 2015 at 03:28:51PM -0500, Bjorn Helgaas wrote: > On Thu, Apr 2, 2015 at 3:20 PM, Luis R. Rodriguez wrote: > > On Thu, Apr 2, 2015 at 1:13 PM, Bjorn Helgaas wrote: > >> > >> On Thu, Mar 26, 2015 at 6:35 PM, Luis R. Rodriguez wrote: > >> > >> > I'll rephrase this to: > >> > > >> >

Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-04-02 Thread Bjorn Helgaas
On Thu, Apr 2, 2015 at 3:20 PM, Luis R. Rodriguez wrote: > On Thu, Apr 2, 2015 at 1:13 PM, Bjorn Helgaas wrote: >> >> On Thu, Mar 26, 2015 at 6:35 PM, Luis R. Rodriguez wrote: >> >> > I'll rephrase this to: >> > >> > --- >> > It is possible to enable CONFIG_MTRR and up with it >> > disabled at r

Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-04-02 Thread Luis R. Rodriguez
On Thu, Apr 2, 2015 at 1:13 PM, Bjorn Helgaas wrote: > > On Thu, Mar 26, 2015 at 6:35 PM, Luis R. Rodriguez wrote: > > > I'll rephrase this to: > > > > --- > > It is possible to enable CONFIG_MTRR and up with it > > disabled at run time and yet CONFIG_X86_PAT continues > > to kick through with al

Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-04-02 Thread Bjorn Helgaas
On Thu, Mar 26, 2015 at 6:35 PM, Luis R. Rodriguez wrote: > I'll rephrase this to: > > --- > It is possible to enable CONFIG_MTRR and up with it > disabled at run time and yet CONFIG_X86_PAT continues > to kick through with all functionally enabled. This > can happen for instance on Xen where MTR

Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-03-27 Thread Luis R. Rodriguez
On Fri, Mar 27, 2015 at 02:40:17PM -0600, Toshi Kani wrote: > On Fri, 2015-03-20 at 16:17 -0700, Luis R. Rodriguez wrote: > : > > @@ -734,6 +742,7 @@ void __init mtrr_bp_init(void) > > } > > > > if (mtrr_if) { > > + mtrr_enabled = true; > > set_num_var_ranges(); > >

Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-03-27 Thread Toshi Kani
On Fri, 2015-03-20 at 16:17 -0700, Luis R. Rodriguez wrote: : > @@ -734,6 +742,7 @@ void __init mtrr_bp_init(void) > } > > if (mtrr_if) { > + mtrr_enabled = true; > set_num_var_ranges(); > init_table(); > if (use_intel()) {

Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-03-26 Thread Luis R. Rodriguez
On Wed, Mar 25, 2015 at 03:59:41PM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Mar 20, 2015 at 04:17:52PM -0700, Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > > > > It is possible to enable CONFIG_MTRR and up with it > > disabled at run time and yet CONFIG_X86_PAT continues > > to ki

Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-03-25 Thread Juergen Gross
On 03/25/2015 08:59 PM, Konrad Rzeszutek Wilk wrote: On Fri, Mar 20, 2015 at 04:17:52PM -0700, Luis R. Rodriguez wrote: From: "Luis R. Rodriguez" It is possible to enable CONFIG_MTRR and up with it disabled at run time and yet CONFIG_X86_PAT continues to kick through fully functionally. This c

Re: [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-03-25 Thread Konrad Rzeszutek Wilk
On Fri, Mar 20, 2015 at 04:17:52PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > It is possible to enable CONFIG_MTRR and up with it > disabled at run time and yet CONFIG_X86_PAT continues > to kick through fully functionally. This can happen s/fully/full/ ? > for instance on

[PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" It is possible to enable CONFIG_MTRR and up with it disabled at run time and yet CONFIG_X86_PAT continues to kick through fully functionally. This can happen for instance on Xen where MTRR is not supported but PAT is, this can happen now on Linux as of commit 47591df50 b