Re: [PATCH v1 03/10] perf/x86/uncore: do not assume PCI fixed ctrs have more than 32 bits

2014-02-11 Thread Stephane Eranian
Yan, In fact, I realized I was not even using all those fixed counter changes, thanks to the pmu bypass from patch 1. So I will drop all of this in V2. It will make the patch simpler. Thanks for catching this. On Mon, Feb 10, 2014 at 4:11 AM, Yan, Zheng wrote: > On 02/03/2014 08:55 PM, Stephan

Re: [PATCH v1 03/10] perf/x86/uncore: do not assume PCI fixed ctrs have more than 32 bits

2014-02-09 Thread Yan, Zheng
On 02/03/2014 08:55 PM, Stephane Eranian wrote: > The current code assumes all PCI fixed counters implement more than > 32-bit hardware counters. The actual width is then round up to 64 to > enable base + 8 * idx calculations. > > Not all PMUs necessarily implement counters with more than 32-bits.

[PATCH v1 03/10] perf/x86/uncore: do not assume PCI fixed ctrs have more than 32 bits

2014-02-03 Thread Stephane Eranian
The current code assumes all PCI fixed counters implement more than 32-bit hardware counters. The actual width is then round up to 64 to enable base + 8 * idx calculations. Not all PMUs necessarily implement counters with more than 32-bits. The patch makes the uncore_pci_perf_ctr() function dynami