Re: [PATCH v1 03/15] perf data: open data directory in read access mode

2020-10-14 Thread Alexey Budankov
On 13.10.2020 19:22, Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 12, 2020 at 07:52:33PM +0300, Alexey Budankov escreveu: >> >> On 12.10.2020 19:03, Andi Kleen wrote: >>> On Mon, Oct 12, 2020 at 11:55:07AM +0300, Alexey Budankov wrote: Open files located at data directory in case of

Re: [PATCH v1 03/15] perf data: open data directory in read access mode

2020-10-13 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 12, 2020 at 07:52:33PM +0300, Alexey Budankov escreveu: > > On 12.10.2020 19:03, Andi Kleen wrote: > > On Mon, Oct 12, 2020 at 11:55:07AM +0300, Alexey Budankov wrote: > >> > >> Open files located at data directory in case of read access mode. > > > > Need some rationale. Is this a

Re: [PATCH v1 03/15] perf data: open data directory in read access mode

2020-10-12 Thread Alexey Budankov
On 12.10.2020 19:03, Andi Kleen wrote: > On Mon, Oct 12, 2020 at 11:55:07AM +0300, Alexey Budankov wrote: >> >> Open files located at data directory in case of read access mode. > > Need some rationale. Is this a bug fix? Did the case not matter > before? This is not a bug fix. The case didn't

Re: [PATCH v1 03/15] perf data: open data directory in read access mode

2020-10-12 Thread Andi Kleen
On Mon, Oct 12, 2020 at 11:55:07AM +0300, Alexey Budankov wrote: > > Open files located at data directory in case of read access mode. Need some rationale. Is this a bug fix? Did the case not matter before? > > Signed-off-by: Alexey Budankov > --- > tools/perf/util/data.c | 4 > 1 file

[PATCH v1 03/15] perf data: open data directory in read access mode

2020-10-12 Thread Alexey Budankov
Open files located at data directory in case of read access mode. Signed-off-by: Alexey Budankov --- tools/perf/util/data.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c index c47aa34fdc0a..6ad61ac6ba67 100644 ---