Re: [PATCH v1 09/16] rtc: mediatek: convert to use device managed functions

2018-03-27 Thread Alexandre Belloni
On 26/03/2018 at 12:07:45 +0800, Sean Wang wrote: > > > - rtc->rtc_dev = rtc_device_register("mt6397-rtc", &pdev->dev, > > > -&mtk_rtc_ops, THIS_MODULE); > > > + rtc->rtc_dev = devm_rtc_device_register(&pdev->dev, "mt6397-rtc", > > > +

Re: [PATCH v1 09/16] rtc: mediatek: convert to use device managed functions

2018-03-25 Thread Sean Wang
On Fri, 2018-03-23 at 11:50 +0100, Alexandre Belloni wrote: > On 23/03/2018 at 17:15:06 +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > Use device managed operation to simplify error handling, reduce source > > code size, and reduce the likelyhood of bugs, and remove our removal

Re: [PATCH v1 09/16] rtc: mediatek: convert to use device managed functions

2018-03-23 Thread Alexandre Belloni
On 23/03/2018 at 17:15:06 +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > Use device managed operation to simplify error handling, reduce source > code size, and reduce the likelyhood of bugs, and remove our removal > callback which contains anything already done by device managed func

[PATCH v1 09/16] rtc: mediatek: convert to use device managed functions

2018-03-23 Thread sean.wang
From: Sean Wang Use device managed operation to simplify error handling, reduce source code size, and reduce the likelyhood of bugs, and remove our removal callback which contains anything already done by device managed functions. Signed-off-by: Sean Wang --- drivers/rtc/rtc-mt6397.c | 31