Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-27 Thread Kuppuswamy, Sathyanarayanan
On 5/26/20 11:41 PM, Yicong Yang wrote: We should do slot reset if driver required, but it's different from the `slot reset` in pci_bus_error_reset(). Previously we don't do a slot reset and call ->slot_reset() directly, I don't know the certain reason. IIUC, your concern is whether it is c

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-26 Thread Yicong Yang
On 2020/5/27 12:04, Kuppuswamy, Sathyanarayanan wrote: > > > On 5/26/20 8:50 PM, Yicong Yang wrote: >> Hi, >> >> >> On 2020/5/27 9:31, Kuppuswamy, Sathyanarayanan wrote: >>> Hi, >>> >>> On 5/21/20 7:56 PM, Yicong Yang wrote: On 2020/5/22 3:31, Kuppuswamy, Sathyanarayanan wrote: >>>

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-26 Thread Kuppuswamy, Sathyanarayanan
On 5/26/20 8:50 PM, Yicong Yang wrote: Hi, On 2020/5/27 9:31, Kuppuswamy, Sathyanarayanan wrote: Hi, On 5/21/20 7:56 PM, Yicong Yang wrote: On 2020/5/22 3:31, Kuppuswamy, Sathyanarayanan wrote: On 5/21/20 3:58 AM, Yicong Yang wrote: On 2020/5/21 1:04, Kuppuswamy, Sathyanarayanan wro

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-26 Thread Yicong Yang
Hi, On 2020/5/27 9:31, Kuppuswamy, Sathyanarayanan wrote: > Hi, > > On 5/21/20 7:56 PM, Yicong Yang wrote: >> >> >> On 2020/5/22 3:31, Kuppuswamy, Sathyanarayanan wrote: >>> >>> >>> On 5/21/20 3:58 AM, Yicong Yang wrote: On 2020/5/21 1:04, Kuppuswamy, Sathyanarayanan wrote: > > >

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-26 Thread Oliver O'Halloran
On Wed, May 27, 2020 at 1:06 PM Kuppuswamy, Sathyanarayanan wrote: > > Yes, in case of DPC (Fatal errors) link is already reset. So we > don't need any special handling. This reset logic is mainly for > non-fatal errors. Why? In our experience most fatal errors aren't all that fatal and can be re

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-26 Thread Kuppuswamy, Sathyanarayanan
Hi, On 5/26/20 8:00 PM, Oliver O'Halloran wrote: On Wed, May 27, 2020 at 12:00 PM Kuppuswamy, Sathyanarayanan wrote: Hi, On 5/21/20 7:56 PM, Yicong Yang wrote: On 2020/5/22 3:31, Kuppuswamy, Sathyanarayanan wrote: Not exactly. In pci_bus_error_reset(), we call pci_slot_reset() only if

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-26 Thread Oliver O'Halloran
On Wed, May 27, 2020 at 12:00 PM Kuppuswamy, Sathyanarayanan wrote: > > Hi, > > On 5/21/20 7:56 PM, Yicong Yang wrote: > > > > > > On 2020/5/22 3:31, Kuppuswamy, Sathyanarayanan wrote: > >> > > Not exactly. In pci_bus_error_reset(), we call pci_slot_reset() only if it's > > hotpluggable. But we al

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-26 Thread Kuppuswamy, Sathyanarayanan
Hi, On 5/21/20 7:56 PM, Yicong Yang wrote: On 2020/5/22 3:31, Kuppuswamy, Sathyanarayanan wrote: On 5/21/20 3:58 AM, Yicong Yang wrote: On 2020/5/21 1:04, Kuppuswamy, Sathyanarayanan wrote: On 5/20/20 1:28 AM, Yicong Yang wrote: On 2020/5/7 11:32, sathyanarayanan.kuppusw...@linux.intel

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-21 Thread Yicong Yang
On 2020/5/22 3:31, Kuppuswamy, Sathyanarayanan wrote: > > > On 5/21/20 3:58 AM, Yicong Yang wrote: >> On 2020/5/21 1:04, Kuppuswamy, Sathyanarayanan wrote: >>> >>> >>> On 5/20/20 1:28 AM, Yicong Yang wrote: On 2020/5/7 11:32, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kup

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-21 Thread Kuppuswamy, Sathyanarayanan
On 5/21/20 3:58 AM, Yicong Yang wrote: On 2020/5/21 1:04, Kuppuswamy, Sathyanarayanan wrote: On 5/20/20 1:28 AM, Yicong Yang wrote: On 2020/5/7 11:32, sathyanarayanan.kuppusw...@linux.intel.com wrote: From: Kuppuswamy Sathyanarayanan If there are non-hotplug capable devices connected to

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-21 Thread Yicong Yang
On 2020/5/21 1:04, Kuppuswamy, Sathyanarayanan wrote: > > > On 5/20/20 1:28 AM, Yicong Yang wrote: >> On 2020/5/7 11:32, sathyanarayanan.kuppusw...@linux.intel.com wrote: >>> From: Kuppuswamy Sathyanarayanan >>> >>> >>> If there are non-hotplug capable devices connected to a given >>> port, then

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-20 Thread Kuppuswamy, Sathyanarayanan
On 5/20/20 1:28 AM, Yicong Yang wrote: On 2020/5/7 11:32, sathyanarayanan.kuppusw...@linux.intel.com wrote: From: Kuppuswamy Sathyanarayanan If there are non-hotplug capable devices connected to a given port, then during the fatal error recovery(triggered by DPC or AER), after calling reset

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-20 Thread Yicong Yang
On 2020/5/7 11:32, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > If there are non-hotplug capable devices connected to a given > port, then during the fatal error recovery(triggered by DPC or > AER), after calling reset_link() function, we cannot rely on

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-14 Thread Kuppuswamy, Sathyanarayanan
Hi Bjorn, On 5/13/20 3:44 PM, Bjorn Helgaas wrote: On Wed, May 06, 2020 at 08:32:59PM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: From: Kuppuswamy Sathyanarayanan If there are non-hotplug capable devices connected to a given port, then during the fatal error recovery(triggered b

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-13 Thread Bjorn Helgaas
On Wed, May 06, 2020 at 08:32:59PM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > If there are non-hotplug capable devices connected to a given > port, then during the fatal error recovery(triggered by DPC or > AER), after calling reset_link() fun

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-12 Thread Yicong Yang
On 2020/5/13 3:20, Jay Vosburgh wrote: > sathyanarayanan.kuppusw...@linux.intel.com wrote: > >> From: Kuppuswamy Sathyanarayanan >> >> If there are non-hotplug capable devices connected to a given >> port, then during the fatal error recovery(triggered by DPC or >> AER), after calling reset_link()

Re: [PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-12 Thread Jay Vosburgh
sathyanarayanan.kuppusw...@linux.intel.com wrote: >From: Kuppuswamy Sathyanarayanan > >If there are non-hotplug capable devices connected to a given >port, then during the fatal error recovery(triggered by DPC or >AER), after calling reset_link() function, we cannot rely on >hotplug handler to de

[PATCH v1 1/1] PCI/ERR: Handle fatal error recovery for non-hotplug capable devices

2020-05-06 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan If there are non-hotplug capable devices connected to a given port, then during the fatal error recovery(triggered by DPC or AER), after calling reset_link() function, we cannot rely on hotplug handler to detach and re-enumerate the device drivers in the affected