Re: [PATCH v1 1/1] PCI/ERR: don't clobber status after reset_link()

2020-10-08 Thread Hedi Berriche
On Fri, Oct 09, 2020 at 05:09 Hedi Berriche wrote: On Fri, Oct 09, 2020 at 04:46 Raj, Ashok wrote: Hi Ashok, Thanks for looking into this. On Fri, Oct 09, 2020 at 03:52:51AM +0100, Hedi Berriche wrote: Commit 6d2c89441571 ("PCI/ERR: Update error status after reset_link()") changed pcie_do_re

Re: [PATCH v1 1/1] PCI/ERR: don't clobber status after reset_link()

2020-10-08 Thread Hedi Berriche
On Fri, Oct 09, 2020 at 04:46 Raj, Ashok wrote: Hi Ashok, Thanks for looking into this. On Fri, Oct 09, 2020 at 03:52:51AM +0100, Hedi Berriche wrote: Commit 6d2c89441571 ("PCI/ERR: Update error status after reset_link()") changed pcie_do_recovery() so that status is updated with the return v

Re: [PATCH v1 1/1] PCI/ERR: don't clobber status after reset_link()

2020-10-08 Thread Raj, Ashok
On Fri, Oct 09, 2020 at 03:52:51AM +0100, Hedi Berriche wrote: > Commit 6d2c89441571 ("PCI/ERR: Update error status after reset_link()") > changed pcie_do_recovery() so that status is updated with the return > value from reset_link(); this was to fix the problem where we would > wrongly report reco

[PATCH v1 1/1] PCI/ERR: don't clobber status after reset_link()

2020-10-08 Thread Hedi Berriche
Commit 6d2c89441571 ("PCI/ERR: Update error status after reset_link()") changed pcie_do_recovery() so that status is updated with the return value from reset_link(); this was to fix the problem where we would wrongly report recovery failure, despite a successful reset_link(), whenever the initial e