Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-24 Thread Simon Horman
On Tue, Apr 23, 2019 at 01:24:08PM +0200, Eugeniu Rosca wrote: > Hi Simon, > > On Tue, Apr 23, 2019 at 12:01:07PM +0200, Simon Horman wrote: > > On Tue, Apr 16, 2019 at 07:48:30PM +0200, Eugeniu Rosca wrote: > > > Hi Jiada, > > > > > > Adding below people, since they've made recent contributions

Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-23 Thread Eugeniu Rosca
Hi Simon, On Tue, Apr 23, 2019 at 12:01:07PM +0200, Simon Horman wrote: > On Tue, Apr 16, 2019 at 07:48:30PM +0200, Eugeniu Rosca wrote: > > Hi Jiada, > > > > Adding below people, since they've made recent contributions to the > > driver and might be interested in your patch: > > > > git log

Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-23 Thread Simon Horman
On Tue, Apr 16, 2019 at 07:48:30PM +0200, Eugeniu Rosca wrote: > Hi Jiada, > > Adding below people, since they've made recent contributions to the > driver and might be interested in your patch: > > git log master --since="1 year" -- drivers/thermal/rcar_gen3_thermal.c \ > | grep -o

Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-18 Thread Jiada Wang
Hi Daniel Thanks for your comments On 2019/04/17 17:05, Daniel Lezcano wrote: On 17/04/2019 05:01, Jiada Wang wrote: Hi Daniel On 2019/04/17 4:22, Daniel Lezcano wrote: On 11/04/2019 12:03, Jiada Wang wrote: Currently IRQ is remain enabled after .remove, later if device is probed, IRQ is

Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-17 Thread Daniel Lezcano
On 17/04/2019 05:01, Jiada Wang wrote: > Hi Daniel > > On 2019/04/17 4:22, Daniel Lezcano wrote: >> On 11/04/2019 12:03, Jiada Wang wrote: >>> Currently IRQ is remain enabled after .remove, later if device is >>> probed, >>> IRQ is requested before .thermal_init, this may cause IRQ function be

Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-16 Thread Jiada Wang
Hi Eugeniu thanks for your test & comments and adding more people for review I will add necessary backtrace information to description and rephrase commit summary in V2 patch Thanks, Jiada On 2019/04/17 2:48, Eugeniu Rosca wrote: Hi Jiada, Adding below people, since they've made recent

Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-16 Thread Jiada Wang
Hi Daniel On 2019/04/17 4:22, Daniel Lezcano wrote: On 11/04/2019 12:03, Jiada Wang wrote: Currently IRQ is remain enabled after .remove, later if device is probed, IRQ is requested before .thermal_init, this may cause IRQ function be triggered but not able to clear IRQ status, thus cause

Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-16 Thread Daniel Lezcano
On 11/04/2019 12:03, Jiada Wang wrote: > Currently IRQ is remain enabled after .remove, later if device is probed, > IRQ is requested before .thermal_init, this may cause IRQ function be > triggered but not able to clear IRQ status, thus cause system to hang. > > this patch by moving request of

Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-16 Thread Eugeniu Rosca
Hi Jiada, Adding below people, since they've made recent contributions to the driver and might be interested in your patch: git log master --since="1 year" -- drivers/thermal/rcar_gen3_thermal.c \ | grep -o "\-by:.*" | sed 's/\-by: //' | sort | uniq -c | sort -rn 7 Eduardo Valentin

[PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

2019-04-11 Thread Jiada Wang
Currently IRQ is remain enabled after .remove, later if device is probed, IRQ is requested before .thermal_init, this may cause IRQ function be triggered but not able to clear IRQ status, thus cause system to hang. this patch by moving request of IRQ after device initialization to avoid this