Re: [alsa-devel] [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID

2019-05-07 Thread Pierre-Louis Bossart
What we are missing are the PCI IDs for CML PCH-LP (0x02C8) and CML PCH-H (0x06C8). Can we respin this patchset to add support for those last two instead of just the -LP case? Sure. So just to clarify, you want the entry for 0x02c8, and you want an additional entry for 0x06c8 under the same

Re: [alsa-devel] [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID

2019-05-07 Thread Evan Green
On Tue, May 7, 2019 at 1:26 PM Pierre-Louis Bossart wrote: > > > > > On 5/6/19 5:53 PM, Evan Green wrote: > >>> Add support for Intel Comet Lake platforms by adding a new Kconfig for > >>> CometLake and the appropriate PCI ID. > > > >> This is odd. I checked internally a few weeks back and the CML

Re: [alsa-devel] [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID

2019-05-07 Thread Pierre-Louis Bossart
On 5/6/19 5:53 PM, Evan Green wrote: Add support for Intel Comet Lake platforms by adding a new Kconfig for CometLake and the appropriate PCI ID. This is odd. I checked internally a few weeks back and the CML PCI ID was 9dc8, same as WHL and CNL, so we did not add a PCI ID on purpose. To

Re: [alsa-devel] [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID

2019-05-07 Thread Pierre-Louis Bossart
; Jaroslav Kysela ; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Takashi Iwai ; Liam Girdwood Subject: Re: [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID On 5/6/19 5:53 PM, Evan Green wrote: Add support for Intel Comet Lake platforms by adding a new Kconfig for CometLake and the

RE: [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID

2019-05-06 Thread M R, Sathya Prakash
; linux-kernel@vger.kernel.org; Takashi Iwai ; Liam Girdwood Subject: Re: [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID On 5/6/19 5:53 PM, Evan Green wrote: >> Add support for Intel Comet Lake platforms by adding a new Kconfig for >> CometLake and the appropriate PCI ID. >

Re: [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID

2019-05-06 Thread Pierre-Louis Bossart
On 5/6/19 5:53 PM, Evan Green wrote: Add support for Intel Comet Lake platforms by adding a new Kconfig for CometLake and the appropriate PCI ID. This is odd. I checked internally a few weeks back and the CML PCI ID was 9dc8, same as WHL and CNL, so we did not add a PCI ID on purpose. To t

[PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID

2019-05-06 Thread Evan Green
Add support for Intel Comet Lake platforms by adding a new Kconfig for CometLake and the appropriate PCI ID. Signed-off-by: Evan Green --- sound/soc/sof/intel/Kconfig | 16 sound/soc/sof/sof-pci-dev.c | 4 2 files changed, 20 insertions(+) diff --git a/sound/soc/sof/inte