Re: [PATCH v1 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2019-01-07 Thread Ivan Mironov
On Mon, 2019-01-07 at 11:08 +0100, Daniel Vetter wrote: > > > > @@ -1654,6 +1712,40 @@ int drm_fb_helper_check_var(struct > > > > fb_var_screeninfo *var, > > > > return -EINVAL; > > > > } > > > > > > > > + /* > > > > +* Workaround for SDL 1.2, which is

Re: [PATCH v1 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2019-01-07 Thread Daniel Vetter
On Sat, Jan 05, 2019 at 09:11:53PM +0500, Ivan Mironov wrote: > On Fri, 2018-12-28 at 13:15 +0100, Daniel Vetter wrote: > > On Fri, Dec 28, 2018 at 04:13:07AM +0500, Ivan Mironov wrote: > > > SDL 1.2 sets all fields related to the pixel format to zero in some > > > cases[1]. Prior to commit

Re: [PATCH v1 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2019-01-05 Thread Ivan Mironov
On Fri, 2018-12-28 at 13:15 +0100, Daniel Vetter wrote: > On Fri, Dec 28, 2018 at 04:13:07AM +0500, Ivan Mironov wrote: > > SDL 1.2 sets all fields related to the pixel format to zero in some > > cases[1]. Prior to commit db05c48197759 ("drm: fb-helper: Reject all > > pixel format changing

Re: [PATCH v1 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2018-12-28 Thread Eugeniy Paltsev
On Fri, 2018-12-28 at 04:13 +0500, Ivan Mironov wrote: > SDL 1.2 sets all fields related to the pixel format to zero in some > cases[1]. Prior to commit db05c48197759 ("drm: fb-helper: Reject all > pixel format changing requests"), there was an unintentional workaround > for this that existed for

Re: [PATCH v1 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2018-12-28 Thread Daniel Vetter
On Fri, Dec 28, 2018 at 04:13:07AM +0500, Ivan Mironov wrote: > SDL 1.2 sets all fields related to the pixel format to zero in some > cases[1]. Prior to commit db05c48197759 ("drm: fb-helper: Reject all > pixel format changing requests"), there was an unintentional workaround > for this that

[PATCH v1 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2018-12-27 Thread Ivan Mironov
SDL 1.2 sets all fields related to the pixel format to zero in some cases[1]. Prior to commit db05c48197759 ("drm: fb-helper: Reject all pixel format changing requests"), there was an unintentional workaround for this that existed for more than a decade. First in device-specific DRM drivers, then