Re: [PATCH v1 1/2] leds: rt4505: Add support for Richtek RT4505 flash led controller

2020-10-28 Thread ChiYuan Huang
Jacek Anaszewski 於 2020年10月28日 週三 下午7:07寫道: > > On 10/28/20 5:57 AM, ChiYuan Huang wrote: > > Hi, > > > > Jacek Anaszewski 於 2020年10月28日 週三 上午12:40寫道: > >> > >> Hi Pavel, ChiYuan, > >> > >> On 10/27/20 9:29 AM, Pavel Machek wrote: > >>> Hi! > >>> > From: ChiYuan Huang > > Add

Re: [PATCH v1 1/2] leds: rt4505: Add support for Richtek RT4505 flash led controller

2020-10-28 Thread Jacek Anaszewski
On 10/28/20 5:57 AM, ChiYuan Huang wrote: Hi, Jacek Anaszewski 於 2020年10月28日 週三 上午12:40寫道: Hi Pavel, ChiYuan, On 10/27/20 9:29 AM, Pavel Machek wrote: Hi! From: ChiYuan Huang Add support for RT4505 flash led controller. It can support up to 1.5A flash current with hardware timeout and

Re: [PATCH v1 1/2] leds: rt4505: Add support for Richtek RT4505 flash led controller

2020-10-28 Thread ChiYuan Huang
Hi, Jacek Anaszewski 於 2020年10月28日 週三 上午12:40寫道: > > Hi Pavel, ChiYuan, > > On 10/27/20 9:29 AM, Pavel Machek wrote: > > Hi! > > > >> From: ChiYuan Huang > >> > >> Add support for RT4505 flash led controller. It can support up to 1.5A > >> flash current with hardware timeout and low input

Re: [PATCH v1 1/2] leds: rt4505: Add support for Richtek RT4505 flash led controller

2020-10-27 Thread ChiYuan Huang
ChiYuan Huang 於 2020年10月27日 週二 下午6:46寫道: > > Pavel Machek 於 2020年10月27日 週二 下午6:15寫道: > > > > Hi! > > > > > > Please use upper-case "LED" everywhere. > > > > > > > > This should be 2nd in the series, after DT changes. > > > Sure, will ack in next series patch. > > > > Feel free to wait for dt

Re: [PATCH v1 1/2] leds: rt4505: Add support for Richtek RT4505 flash led controller

2020-10-27 Thread Jacek Anaszewski
Hi Pavel, ChiYuan, On 10/27/20 9:29 AM, Pavel Machek wrote: Hi! From: ChiYuan Huang Add support for RT4505 flash led controller. It can support up to 1.5A flash current with hardware timeout and low input voltage protection. Please use upper-case "LED" everywhere. This should be 2nd in

Re: [PATCH v1 1/2] leds: rt4505: Add support for Richtek RT4505 flash led controller

2020-10-27 Thread ChiYuan Huang
Pavel Machek 於 2020年10月27日 週二 下午6:15寫道: > > Hi! > > > > Please use upper-case "LED" everywhere. > > > > > > This should be 2nd in the series, after DT changes. > > Sure, will ack in next series patch. > > Feel free to wait for dt ACKs before resending. > Yes, sure. > > > > + help > > > > +

Re: [PATCH v1 1/2] leds: rt4505: Add support for Richtek RT4505 flash led controller

2020-10-27 Thread Pavel Machek
Hi! > > Please use upper-case "LED" everywhere. > > > > This should be 2nd in the series, after DT changes. > Sure, will ack in next series patch. Feel free to wait for dt ACKs before resending. > > > + help > > > + This option enables support for the RT4505 flash led controller. > >

Re: [PATCH v1 1/2] leds: rt4505: Add support for Richtek RT4505 flash led controller

2020-10-27 Thread Pavel Machek
Hi! > Continue the last mail, I'm confused about the rule 80-characters-per-line. > I check some information about submitting changes. > https://www.phoronix.com/scan.php?page=news_item=Linux-Kernel-Deprecates-80-Col > Could you help to explain the current rule about this limit? still 80 >

Re: [PATCH v1 1/2] leds: rt4505: Add support for Richtek RT4505 flash led controller

2020-10-27 Thread ChiYuan Huang
Hi, Parvel: Continue the last mail, I'm confused about the rule 80-characters-per-line. I check some information about submitting changes. https://www.phoronix.com/scan.php?page=news_item=Linux-Kernel-Deprecates-80-Col Could you help to explain the current rule about this limit? still 80

Re: [PATCH v1 1/2] leds: rt4505: Add support for Richtek RT4505 flash led controller

2020-10-27 Thread ChiYuan Huang
Pavel Machek 於 2020年10月27日 週二 下午4:29寫道: > > Hi! > > > From: ChiYuan Huang > > > > Add support for RT4505 flash led controller. It can support up to 1.5A > > flash current with hardware timeout and low input voltage > > protection. > > Please use upper-case "LED" everywhere. > > This should be

Re: [PATCH v1 1/2] leds: rt4505: Add support for Richtek RT4505 flash led controller

2020-10-27 Thread Pavel Machek
Hi! > From: ChiYuan Huang > > Add support for RT4505 flash led controller. It can support up to 1.5A > flash current with hardware timeout and low input voltage > protection. Please use upper-case "LED" everywhere. This should be 2nd in the series, after DT changes. > Signed-off-by: ChiYuan

[PATCH v1 1/2] leds: rt4505: Add support for Richtek RT4505 flash led controller

2020-10-27 Thread cy_huang
From: ChiYuan Huang Add support for RT4505 flash led controller. It can support up to 1.5A flash current with hardware timeout and low input voltage protection. Signed-off-by: ChiYuan Huang --- drivers/leds/Kconfig | 11 ++ drivers/leds/Makefile | 1 + drivers/leds/leds-rt4505.c