Re: [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version

2016-01-04 Thread Wolfram Sang
> >> +static int rk3x_i2c_v0_calc_divs(unsigned long clk_rate, unsigned long > >> scl_rate, > >> +unsigned long scl_rise_ns, > >> +unsigned long scl_fall_ns, > >> +unsigned long sda_fall_ns, > > Wolfram

Re: [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version

2015-12-20 Thread Andy Shevchenko
On Tue, Dec 15, 2015 at 2:32 AM, Jianqun Xu wrote: > Hi David: > > It's better to add a cover-letter, and add changes note for new version, > such as: > > changes since v0: > - split patch to two patches or more, one patch for one new feature (Heiko) > > and NOT to have two same signed-off-by Bes

Re: [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version

2015-12-14 Thread Jianqun Xu
Hi David: It's better to add a cover-letter, and add changes note for new version, such as: changes since v0: - split patch to two patches or more, one patch for one new feature (Heiko) and NOT to have two same signed-off-by 在 11/12/2015 22:33, David Wu 写道: The calc_divs of new version is dif

[PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version

2015-12-11 Thread David Wu
The calc_divs of new version is different form the old. The time of tHD;sda, tHD;sda, tSU;sta, tHD;sta and tSU;sto could be configured by RKI2C_CON register. So it need a new way to calc_divs for new i2c controller. Signed-off-by: David Wu Signed-off-by: David Wu --- drivers/i2c/busses/i2c-rk3