Re: [PATCH v1 1/3] net: stmmac:sti: Add STi SOC glue driver.

2014-02-07 Thread srinivas kandagatla
Thankyou Dave, On 07/02/14 03:53, David Miller wrote: > From: > Date: Mon, 3 Feb 2014 12:01:08 + > >> +res = platform_get_resource_byname(pdev, >> +IORESOURCE_MEM, "sti-ethconf"); > > This is not the correct way to format multi-line function calls, > you'll n

Re: [PATCH v1 1/3] net: stmmac:sti: Add STi SOC glue driver.

2014-02-06 Thread David Miller
From: Date: Mon, 3 Feb 2014 12:01:08 + > + res = platform_get_resource_byname(pdev, > + IORESOURCE_MEM, "sti-ethconf"); This is not the correct way to format multi-line function calls, you'll need to fix this up in this entire series. The arguments on the sec

[PATCH v1 1/3] net: stmmac:sti: Add STi SOC glue driver.

2014-02-03 Thread srinivas.kandagatla
From: Srinivas Kandagatla STi series SOCs have a glue layer on top of the synopsis gmac IP, this glue layer needs to be configured before the gmac driver starts using the IP. This patch adds a support to this glue layer which is configured via stmmac setup, init, exit callbacks. Signed-off-by: