Re: [PATCH v1 1/3] usb: gadget: NCM: RX function support multiple NDPs

2014-05-30 Thread Jim Baxter
On 29/05/14 19:55, Bjørn Mork wrote: > Jim Baxter writes: > >> The NDP was ignoring the wNextNdpIndex in the NDP which >> means that NTBs containing multiple NDPs would have missed >> frames. > > Well, just for the record: I believe this field was meant to be reserved > and always 0 in the CDC

Re: [PATCH v1 1/3] usb: gadget: NCM: RX function support multiple NDPs

2014-05-30 Thread Jim Baxter
On 29/05/14 19:55, Bjørn Mork wrote: Jim Baxter jim_bax...@mentor.com writes: The NDP was ignoring the wNextNdpIndex in the NDP which means that NTBs containing multiple NDPs would have missed frames. Well, just for the record: I believe this field was meant to be reserved and always 0

Re: [PATCH v1 1/3] usb: gadget: NCM: RX function support multiple NDPs

2014-05-29 Thread Bjørn Mork
Jim Baxter writes: > The NDP was ignoring the wNextNdpIndex in the NDP which > means that NTBs containing multiple NDPs would have missed > frames. Well, just for the record: I believe this field was meant to be reserved and always 0 in the CDC NCM spec. Table 3-3, describing 16bit NDPs, says

[PATCH v1 1/3] usb: gadget: NCM: RX function support multiple NDPs

2014-05-29 Thread Jim Baxter
The NDP was ignoring the wNextNdpIndex in the NDP which means that NTBs containing multiple NDPs would have missed frames. Signed-off-by: Jim Baxter --- drivers/usb/gadget/f_ncm.c | 146 +++- 1 file changed, 78 insertions(+), 68 deletions(-) diff --git

[PATCH v1 1/3] usb: gadget: NCM: RX function support multiple NDPs

2014-05-29 Thread Jim Baxter
The NDP was ignoring the wNextNdpIndex in the NDP which means that NTBs containing multiple NDPs would have missed frames. Signed-off-by: Jim Baxter jim_bax...@mentor.com --- drivers/usb/gadget/f_ncm.c | 146 +++- 1 file changed, 78 insertions(+), 68

Re: [PATCH v1 1/3] usb: gadget: NCM: RX function support multiple NDPs

2014-05-29 Thread Bjørn Mork
Jim Baxter jim_bax...@mentor.com writes: The NDP was ignoring the wNextNdpIndex in the NDP which means that NTBs containing multiple NDPs would have missed frames. Well, just for the record: I believe this field was meant to be reserved and always 0 in the CDC NCM spec. Table 3-3, describing