答复: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

2019-05-24 Thread TonyWWang-oc
On Thu, May 23, 2019, Thomas Gleixner wrote: >> + * This file is licensed under the terms of the GNU General >> + * License v2.0 or later. See file COPYING for details. > >Please remove this boilerplate text. The SPDX license identifier is >sufficient, but looking at that: > >> +//

答复: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

2019-05-24 Thread TonyWWang-oc
On Thu, May 23, 2019, Borislav Petkov wrote: >> This patch is totally corrupted, with leading spaces dropped and tabs >> turned into spaces. Please read the email client documentation in the >> kernel directory for how to fix your email client, or just use 'git >> send-email' to send the patches

答复: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

2019-05-24 Thread TonyWWang-oc
On Thu, May 23, 2019, gre...@linuxfoundation.org wrote: >> To identify Zhaoxin CPU, add a new vendor type X86_VENDOR_ZHAOXIN >> for system recognition. >> >> Signed-off-by: TonyWWang > >Some basic patch tips. Your From: line needs to match the signed-off-by >line, which is not true here. Also,

答复: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

2019-05-24 Thread TonyWWang-oc
On Thu, May 23, 2019, gre...@linuxfoundation.org wrote: >> + * This file is licensed under the terms of the GNU General >> + * License v2.0 or later. See file COPYING for details. > >That contridicts the first line of the file :( > >Please sort this out with your lawyers and resend it corrected. >

Re: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

2019-05-23 Thread Thomas Gleixner
On Thu, 23 May 2019, TonyWWang-oc wrote: > --- /dev/null > +++ b/arch/x86/kernel/cpu/zhaoxin.c > @@ -0,0 +1,178 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Zhaoxin Processor Support for Linux > + * > + * Copyright (c) 2019 Shanghai Zhaoxin Semiconductor Co., Ltd. > + * > + * Author:

Re: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

2019-05-23 Thread Borislav Petkov
On Thu, May 23, 2019 at 12:24:17PM +0200, gre...@linuxfoundation.org wrote: > This patch is totally corrupted, with leading spaces dropped and tabs > turned into spaces. Please read the email client documentation in the > kernel directory for how to fix your email client, or just use 'git >

Re: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

2019-05-23 Thread gre...@linuxfoundation.org
On Thu, May 23, 2019 at 10:10:52AM +, TonyWWang-oc wrote: > Add x86 architecture support for new Zhaoxin processors. > Carve out initialization code needed by Zhaoxin processors into > a separate compilation unit. > > To identify Zhaoxin CPU, add a new vendor type X86_VENDOR_ZHAOXIN > for

Re: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

2019-05-23 Thread gre...@linuxfoundation.org
On Thu, May 23, 2019 at 10:10:52AM +, TonyWWang-oc wrote: > --- /dev/null > +++ b/arch/x86/kernel/cpu/zhaoxin.c > @@ -0,0 +1,178 @@ > +// SPDX-License-Identifier: GPL-2.0 Nice, but: > +/* > + * Zhaoxin Processor Support for Linux > + * > + * Copyright (c) 2019 Shanghai Zhaoxin Semiconductor

Re: [PATCH v1 1/3] x86/cpu: Create Zhaoxin processors architecture support file

2019-05-23 Thread gre...@linuxfoundation.org
On Thu, May 23, 2019 at 10:10:52AM +, TonyWWang-oc wrote: > Add x86 architecture support for new Zhaoxin processors. > Carve out initialization code needed by Zhaoxin processors into > a separate compilation unit. > > To identify Zhaoxin CPU, add a new vendor type X86_VENDOR_ZHAOXIN > for