Re: [PATCH v1 1/4] mm/memory_hotplug: Release memory resource after arch_remove_memory()

On 17.04.19 15:31, Michal Hocko wrote: > On Wed 17-04-19 15:24:47, David Hildenbrand wrote: >> On 17.04.19 15:12, Michal Hocko wrote: >>> On Tue 09-04-19 12:01:45, David Hildenbrand wrote: __add_pages() doesn't add the memory resource, so __remove_pages() shouldn't remove it. Let's

Re: [PATCH v1 1/4] mm/memory_hotplug: Release memory resource after arch_remove_memory()

On Wed 17-04-19 15:24:47, David Hildenbrand wrote: > On 17.04.19 15:12, Michal Hocko wrote: > > On Tue 09-04-19 12:01:45, David Hildenbrand wrote: > >> __add_pages() doesn't add the memory resource, so __remove_pages() > >> shouldn't remove it. Let's factor it out. Especially as it is a special >

Re: [PATCH v1 1/4] mm/memory_hotplug: Release memory resource after arch_remove_memory()

On 17.04.19 15:12, Michal Hocko wrote: > On Tue 09-04-19 12:01:45, David Hildenbrand wrote: >> __add_pages() doesn't add the memory resource, so __remove_pages() >> shouldn't remove it. Let's factor it out. Especially as it is a special >> case for memory used as system memory, added via

Re: [PATCH v1 1/4] mm/memory_hotplug: Release memory resource after arch_remove_memory()

On Tue 09-04-19 12:01:45, David Hildenbrand wrote: > __add_pages() doesn't add the memory resource, so __remove_pages() > shouldn't remove it. Let's factor it out. Especially as it is a special > case for memory used as system memory, added via add_memory() and > friends. > > We now remove the

Re: [PATCH v1 1/4] mm/memory_hotplug: Release memory resource after arch_remove_memory()

On Tue, 2019-04-09 at 12:01 +0200, David Hildenbrand wrote: > __add_pages() doesn't add the memory resource, so __remove_pages() > shouldn't remove it. Let's factor it out. Especially as it is a > special > case for memory used as system memory, added via add_memory() and > friends. I would call

Re: [PATCH v1 1/4] mm/memory_hotplug: Release memory resource after arch_remove_memory()

On 17.04.19 05:37, Andrew Morton wrote: > On Wed, 10 Apr 2019 10:07:24 +0200 David Hildenbrand wrote: > >> Care to fixup both u64 to resource_size_t? Or should I send a patch? >> Whatever you prefer. > > Please send along a fixup. Will do! > > This patch series has no evidence of having been

Re: [PATCH v1 1/4] mm/memory_hotplug: Release memory resource after arch_remove_memory()

On Wed, 10 Apr 2019 10:07:24 +0200 David Hildenbrand wrote: > Care to fixup both u64 to resource_size_t? Or should I send a patch? > Whatever you prefer. Please send along a fixup. This patch series has no evidence of having been reviewed :(. Can you suggest who could help us out here?

Re: [PATCH v1 1/4] mm/memory_hotplug: Release memory resource after arch_remove_memory()

On 10.04.19 00:41, Andrew Morton wrote: > On Tue, 9 Apr 2019 12:01:45 +0200 David Hildenbrand wrote: > >> __add_pages() doesn't add the memory resource, so __remove_pages() >> shouldn't remove it. Let's factor it out. Especially as it is a special >> case for memory used as system memory, added

Re: [PATCH v1 1/4] mm/memory_hotplug: Release memory resource after arch_remove_memory()

On Tue, 9 Apr 2019 12:01:45 +0200 David Hildenbrand wrote: > __add_pages() doesn't add the memory resource, so __remove_pages() > shouldn't remove it. Let's factor it out. Especially as it is a special > case for memory used as system memory, added via add_memory() and > friends. > > We now

[PATCH v1 1/4] mm/memory_hotplug: Release memory resource after arch_remove_memory()

__add_pages() doesn't add the memory resource, so __remove_pages() shouldn't remove it. Let's factor it out. Especially as it is a special case for memory used as system memory, added via add_memory() and friends. We now remove the resource after removing the sections instead of doing it the