Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-16 Thread Coiby Xu
On Thu, Oct 15, 2020 at 08:06:06PM +0900, Benjamin Poirier wrote: On 2020-10-15 11:37 +0800, Coiby Xu wrote: On Tue, Oct 13, 2020 at 09:37:04AM +0900, Benjamin Poirier wrote: > On 2020-10-12 19:24 +0800, Coiby Xu wrote: > [...] > > > I think, but didn't check in depth, that in those drivers,

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-15 Thread Benjamin Poirier
On 2020-10-15 11:37 +0800, Coiby Xu wrote: > On Tue, Oct 13, 2020 at 09:37:04AM +0900, Benjamin Poirier wrote: > > On 2020-10-12 19:24 +0800, Coiby Xu wrote: > > [...] > > > > I think, but didn't check in depth, that in those drivers, the devlink > > > > device is tied to the pci device and can

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-14 Thread Coiby Xu
On Tue, Oct 13, 2020 at 09:37:04AM +0900, Benjamin Poirier wrote: On 2020-10-12 19:24 +0800, Coiby Xu wrote: [...] > I think, but didn't check in depth, that in those drivers, the devlink > device is tied to the pci device and can exist independently of the > netdev, at least in principle. >

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-12 Thread Benjamin Poirier
On 2020-10-12 19:24 +0800, Coiby Xu wrote: [...] > > I think, but didn't check in depth, that in those drivers, the devlink > > device is tied to the pci device and can exist independently of the > > netdev, at least in principle. > > > You are right. Take drivers/net/ethernet/mellanox/mlxsw as

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-12 Thread Coiby Xu
On Sat, Oct 10, 2020 at 10:48:55PM +0900, Benjamin Poirier wrote: On 2020-10-10 18:24 +0800, Coiby Xu wrote: On Sat, Oct 10, 2020 at 04:35:14PM +0900, Benjamin Poirier wrote: > On 2020-10-08 19:58 +0800, Coiby Xu wrote: > > Initialize devlink health dump framework for the dlge driver so the > >

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-12 Thread Coiby Xu
On Thu, Oct 08, 2020 at 08:22:44AM -0400, Willem de Bruijn wrote: On Thu, Oct 8, 2020 at 7:58 AM Coiby Xu wrote: Initialize devlink health dump framework for the dlge driver so the coredump could be done via devlink. Signed-off-by: Coiby Xu @@ -4556,6 +4559,13 @@ static int

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-10 Thread Benjamin Poirier
On 2020-10-10 18:24 +0800, Coiby Xu wrote: > On Sat, Oct 10, 2020 at 04:35:14PM +0900, Benjamin Poirier wrote: > > On 2020-10-08 19:58 +0800, Coiby Xu wrote: > > > Initialize devlink health dump framework for the dlge driver so the > > > coredump could be done via devlink. > > > > > >

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-10 Thread Coiby Xu
On Sat, Oct 10, 2020 at 04:35:14PM +0900, Benjamin Poirier wrote: On 2020-10-08 19:58 +0800, Coiby Xu wrote: Initialize devlink health dump framework for the dlge driver so the coredump could be done via devlink. Signed-off-by: Coiby Xu --- drivers/staging/qlge/Kconfig| 1 +

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-10 Thread Benjamin Poirier
On 2020-10-08 19:58 +0800, Coiby Xu wrote: > Initialize devlink health dump framework for the dlge driver so the > coredump could be done via devlink. > > Signed-off-by: Coiby Xu > --- > drivers/staging/qlge/Kconfig| 1 + > drivers/staging/qlge/Makefile | 2 +- >

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-08 Thread Coiby Xu
On Thu, Oct 08, 2020 at 04:31:42PM +0300, Dan Carpenter wrote: On Thu, Oct 08, 2020 at 07:58:03PM +0800, Coiby Xu wrote: Initialize devlink health dump framework for the dlge driver so the coredump could be done via devlink. Signed-off-by: Coiby Xu --- drivers/staging/qlge/Kconfig|

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-08 Thread kernel test robot
Hi Coiby, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Coiby-Xu/staging-qlge-Re-writing-the-debugging-features/20201008-22 base:

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-08 Thread Dan Carpenter
On Thu, Oct 08, 2020 at 07:58:03PM +0800, Coiby Xu wrote: > Initialize devlink health dump framework for the dlge driver so the > coredump could be done via devlink. > > Signed-off-by: Coiby Xu > --- > drivers/staging/qlge/Kconfig| 1 + > drivers/staging/qlge/Makefile | 2 +- >

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-08 Thread Coiby Xu
On Thu, Oct 08, 2020 at 08:22:44AM -0400, Willem de Bruijn wrote: On Thu, Oct 8, 2020 at 7:58 AM Coiby Xu wrote: Initialize devlink health dump framework for the dlge driver so the coredump could be done via devlink. Signed-off-by: Coiby Xu @@ -4556,6 +4559,13 @@ static int

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-08 Thread Willem de Bruijn
On Thu, Oct 8, 2020 at 7:58 AM Coiby Xu wrote: > > Initialize devlink health dump framework for the dlge driver so the > coredump could be done via devlink. > > Signed-off-by: Coiby Xu > @@ -4556,6 +4559,13 @@ static int qlge_probe(struct pci_dev *pdev, > struct ql_adapter *qdev = NULL;

[PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-08 Thread Coiby Xu
Initialize devlink health dump framework for the dlge driver so the coredump could be done via devlink. Signed-off-by: Coiby Xu --- drivers/staging/qlge/Kconfig| 1 + drivers/staging/qlge/Makefile | 2 +- drivers/staging/qlge/qlge.h | 9 +++