Re: [PATCH v1 1/7] soc: imx: gpcv2: check for errors when r/w registers

2021-04-12 Thread Andrey Smirnov
On Wed, Apr 7, 2021 at 2:21 PM Adrien Grassein wrote: > > Errors were not checked after each access to registers FWIW, I didn't write any error checking code on purpose since all of those are memory mapped registers and I don't think there's a case for those to error out. Don't have a strong opin

[PATCH v1 1/7] soc: imx: gpcv2: check for errors when r/w registers

2021-04-07 Thread Adrien Grassein
Errors were not checked after each access to registers and clocks initialisation. Signed-off-by: Adrien Grassein --- drivers/soc/imx/gpcv2.c | 62 ++--- 1 file changed, 45 insertions(+), 17 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/g