Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled

Hi Lowry, Based on Daniel's input, this patch looks fine: Reviewed-by: Brian Starkey I think there's some opportunity for improvement around prepare_signaling/complete_signaling, but that can be treated as separate from fixing this bug. Thanks, -Brian On Wed, Jul 31, 2019 at 11:04:45AM +,

Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled

On Fri, Aug 2, 2019 at 11:43 AM Daniel Vetter wrote: > > On Fri, Aug 2, 2019 at 11:29 AM Brian Starkey wrote: > > > > Hi Lowry, > > > > On Thu, Aug 01, 2019 at 06:34:08AM +, Lowry Li (Arm Technology China) > > wrote: > > > Hi Brian, > > > > > > On Wed, Jul 31, 2019 at 09:20:04PM +0800, Brian

Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled

Hi Lowry, Thanks for this cleanup. On Wed, Jul 31, 2019 at 11:04:45AM +, Lowry Li (Arm Technology China) wrote: > During it signals the completion of a writeback job, after releasing > the out_fence, we'd clear the pointer. > > Check if fence left over in drm_writeback_cleanup_job(), release