Re: [PATCH v1 2/2] extcon: mrfld: Introduce extcon driver for Basin Cove PMIC

2019-03-18 Thread Chanwoo Choi
Hi Andy, On 19. 3. 18. 오후 9:46, Andy Shevchenko wrote: > On Mon, Mar 18, 2019 at 07:38:26PM +0900, Chanwoo Choi wrote: > >> Thanks for comment. I add my comments >> and then you have to rebase it on latest v5.0-rc1 >> because the merge conflict happen on v5.0-rc1. > > Thanks for review, see my a

Re: [PATCH v1 2/2] extcon: mrfld: Introduce extcon driver for Basin Cove PMIC

2019-03-18 Thread Andy Shevchenko
On Mon, Mar 18, 2019 at 07:38:26PM +0900, Chanwoo Choi wrote: > Thanks for comment. I add my comments > and then you have to rebase it on latest v5.0-rc1 > because the merge conflict happen on v5.0-rc1. Thanks for review, see my answers below. Non-answered items will be fixed accordingly. > >> +

Re: [PATCH v1 2/2] extcon: mrfld: Introduce extcon driver for Basin Cove PMIC

2019-03-18 Thread Chanwoo Choi
Hi Andy, On 19. 3. 18. 오후 7:38, Chanwoo Choi wrote: > Hi Andy, > > Thanks for comment. I add my comments > and then you have to rebase it on latest v5.0-rc1 > because the merge conflict happen on v5.0-rc1. Please rebase the extcon-next branch instead of v5.0-rc1. > > On 19. 3. 18. 오후 7:11, And

Re: [PATCH v1 2/2] extcon: mrfld: Introduce extcon driver for Basin Cove PMIC

2019-03-18 Thread Chanwoo Choi
Hi Andy, Thanks for comment. I add my comments and then you have to rebase it on latest v5.0-rc1 because the merge conflict happen on v5.0-rc1. On 19. 3. 18. 오후 7:11, Andy Shevchenko wrote: > On Mon, Mar 18, 2019 at 12:52:25PM +0300, Andy Shevchenko wrote: >> TBD > > Oops. > I though I have writ

Re: [PATCH v1 2/2] extcon: mrfld: Introduce extcon driver for Basin Cove PMIC

2019-03-18 Thread Andy Shevchenko
On Mon, Mar 18, 2019 at 12:52:25PM +0300, Andy Shevchenko wrote: > TBD Oops. I though I have written it already. I will wait for other comments today and sent a new version with commit message filled as follows: On Intel Merrifield the Basin Cove PMIC provides a feature to detect the USB connect

[PATCH v1 2/2] extcon: mrfld: Introduce extcon driver for Basin Cove PMIC

2019-03-18 Thread Andy Shevchenko
TBD Signed-off-by: Andy Shevchenko --- drivers/extcon/Kconfig | 7 + drivers/extcon/Makefile | 1 + drivers/extcon/extcon-intel-mrfld.c | 256 3 files changed, 264 insertions(+) create mode 100644 drivers/extcon/extcon-intel-mrfld.c dif