Re: [PATCH v1 2/2] net: npcm: add NPCM7xx EMC 10/100 Ethernet driver

2019-08-06 Thread Willem de Bruijn
> > Does this device support stacked VLAN? > I am not familiar with stacked VLAN. > Our HW for sure there is no support. can the SW stack handle it for me? > Does it mean that the packets can be larger? If the device does not support it, I believe it's fine to leave it to S/W. > > Is this really

Re: [PATCH v1 2/2] net: npcm: add NPCM7xx EMC 10/100 Ethernet driver

2019-08-06 Thread Avi Fishman
Thanks for the input Willem, Before I will submit a new version please help me with some questions: On Thu, Aug 1, 2019 at 8:26 PM Willem de Bruijn wrote: > > On Thu, Aug 1, 2019 at 3:28 AM Avi Fishman wrote: > > > > EMC Ethernet Media Access Controller supports 10/100 Mbps and > > RMII. > > Th

Re: [PATCH v1 2/2] net: npcm: add NPCM7xx EMC 10/100 Ethernet driver

2019-08-01 Thread Willem de Bruijn
On Thu, Aug 1, 2019 at 3:28 AM Avi Fishman wrote: > > EMC Ethernet Media Access Controller supports 10/100 Mbps and > RMII. > This driver has been working on Nuvoton BMC NPCM7xx. > > Signed-off-by: Avi Fishman > +/* global setting for driver */ > +#define RX_QUEUE_LEN 128 > +#define TX_QUEUE

Re: [PATCH v1 2/2] net: npcm: add NPCM7xx EMC 10/100 Ethernet driver

2019-08-01 Thread David Miller
From: Avi Fishman Date: Thu, 1 Aug 2019 10:26:11 +0300 > +#Eternet 10/100 EMC "Ethernet" > +#ifdef CONFIG_NPCM7XX_EMC_ETH_DEBUG > +#define DEBUG > +#endif Please don't control the DEBUG define in this way. > +#if defined CONFIG_NPCM7XX_EMC_ETH_DEBUG || defined CONFIG_DEBUG_FS > +#define REG_

[PATCH v1 2/2] net: npcm: add NPCM7xx EMC 10/100 Ethernet driver

2019-08-01 Thread Avi Fishman
EMC Ethernet Media Access Controller supports 10/100 Mbps and RMII. This driver has been working on Nuvoton BMC NPCM7xx. Signed-off-by: Avi Fishman --- drivers/net/ethernet/nuvoton/Kconfig | 21 +- drivers/net/ethernet/nuvoton/Makefile |2 + drivers/net/ethernet/nuvoton/npcm7xx_