Re: [PATCH v1 2/3] ASoC: rsnd: Allow reconfiguration of clock rate

Hi Jiada > > 2nd, can we keep usrcnt setup as-is ? > > I guess we can just avoid rsnd_ssi_master_clk_start() if ssi->rate was not > > 0 ? > > I don't fully understand your 2nd question, > in case of rsnd_ssi_master_clk_stop(), if avoid > rsnd_ssi_master_clk_stop() when ssi->rate is 0 by apply

Re: [PATCH v1 2/3] ASoC: rsnd: Allow reconfiguration of clock rate

Hi Morimoto-san Sorry for the delayed response On 2019/07/22 17:41, Kuninori Morimoto wrote: Hi Jiada The solution looks very over-kill to me, especiallyq [3/3] patch is too much to me. 1st, can we start clock at .hw_param, instead of .prepare ? and stop it at .hw_free ? the reasoning to m

Re: [PATCH v1 2/3] ASoC: rsnd: Allow reconfiguration of clock rate

Hi Jiada, again > The solution looks very over-kill to me, > especiallyq [3/3] patch is too much to me. > > 1st, can we start clock at .hw_param, instead of .prepare ? > and stop it at .hw_free ? > > 2nd, can we keep usrcnt setup as-is ? > I guess we can just avoid rsnd_ssi_master_clk_start()

Re: [PATCH v1 2/3] ASoC: rsnd: Allow reconfiguration of clock rate

Hi Jiada The solution looks very over-kill to me, especiallyq [3/3] patch is too much to me. 1st, can we start clock at .hw_param, instead of .prepare ? and stop it at .hw_free ? 2nd, can we keep usrcnt setup as-is ? I guess we can just avoid rsnd_ssi_master_clk_start() if ssi->rate was not 0

[PATCH v1 2/3] ASoC: rsnd: Allow reconfiguration of clock rate

From: Timo Wischer Currently after clock rate is started in .prepare reconfiguration of clock rate is not allowed, unless the stream is stopped. But there is use case in Gstreamer ALSA sink, in case of changed caps Gsreatmer reconfigs and it calls snd_pcm_hw_free() before snd_pcm_prepre(). See g