Re: [PATCH v1 2/3] pstore/ram: allow to dump kmesg during regular reboot

2020-05-04 Thread Kees Cook
On Mon, May 04, 2020 at 04:30:52PM -0400, Pavel Tatashin wrote: > > > -static void pstore_register_kmsg(void) > > > +static void pstore_register_kmsg(int dmesg_all) > > > { > > > + if (dmesg_all) > > > + pstore_dumper.max_reason = KMSG_DUMP_MAX; > > > > So, I'd like to avoid any

Re: [PATCH v1 2/3] pstore/ram: allow to dump kmesg during regular reboot

2020-05-04 Thread Pavel Tatashin
> > -static void pstore_register_kmsg(void) > > +static void pstore_register_kmsg(int dmesg_all) > > { > > + if (dmesg_all) > > + pstore_dumper.max_reason = KMSG_DUMP_MAX; > > So, I'd like to avoid any new arguments in the API and instead add a new > field to struct pstore_info,

Re: [PATCH v1 2/3] pstore/ram: allow to dump kmesg during regular reboot

2020-05-04 Thread Kees Cook
On Sat, May 02, 2020 at 10:35:54AM -0400, Pavel Tatashin wrote: > Currently, ramoops is capable to collect dmesg buffer only during > panic and oops events. However, it is desirable to optionally allow > collecting dmesg buffers during other events as well: reboot, kexec, > emergency reboot etc. >

[PATCH v1 2/3] pstore/ram: allow to dump kmesg during regular reboot

2020-05-02 Thread Pavel Tatashin
Currently, ramoops is capable to collect dmesg buffer only during panic and oops events. However, it is desirable to optionally allow collecting dmesg buffers during other events as well: reboot, kexec, emergency reboot etc. While, a similar functionality is provided by pstore console it is not