Re: [PATCH v1 2/4] dmaengine: imx-sdma: add check_bd_buswidth() to kill the dulicated code

2018-07-11 Thread Sascha Hauer
On Wed, Jul 11, 2018 at 12:23:11AM +0800, Robin Gong wrote: > Add check_bd_buswidth() to minimize the code size. > > Signed-off-by: Robin Gong > --- > drivers/dma/imx-sdma.c | 64 > +++--- > 1 file changed, 29 insertions(+), 35 deletions(-) > > diff

Re: [PATCH v1 2/4] dmaengine: imx-sdma: add check_bd_buswidth() to kill the dulicated code

2018-07-11 Thread Sascha Hauer
On Wed, Jul 11, 2018 at 12:23:11AM +0800, Robin Gong wrote: > Add check_bd_buswidth() to minimize the code size. > > Signed-off-by: Robin Gong > --- > drivers/dma/imx-sdma.c | 64 > +++--- > 1 file changed, 29 insertions(+), 35 deletions(-) > > diff

RE: [PATCH v1 2/4] dmaengine: imx-sdma: add check_bd_buswidth() to kill the dulicated code

2018-07-10 Thread Robin Gong
t; ker...@pengutronix.de; dmaeng...@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH v1 2/4] dmaengine: imx-sdma: add check_bd_buswidth() to > kill the dulicated code > > On 11-07-18, 00:23, Robin Gong wrote: > > Add check_bd_buswidth() to minimi

RE: [PATCH v1 2/4] dmaengine: imx-sdma: add check_bd_buswidth() to kill the dulicated code

2018-07-10 Thread Robin Gong
t; ker...@pengutronix.de; dmaeng...@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH v1 2/4] dmaengine: imx-sdma: add check_bd_buswidth() to > kill the dulicated code > > On 11-07-18, 00:23, Robin Gong wrote: > > Add check_bd_buswidth() to minimi

Re: [PATCH v1 2/4] dmaengine: imx-sdma: add check_bd_buswidth() to kill the dulicated code

2018-07-10 Thread Vinod
On 11-07-18, 00:23, Robin Gong wrote: > Add check_bd_buswidth() to minimize the code size. this looks mostly fine and I think this should be first patch.. > > Signed-off-by: Robin Gong > --- > drivers/dma/imx-sdma.c | 64 > +++--- > 1 file changed,

Re: [PATCH v1 2/4] dmaengine: imx-sdma: add check_bd_buswidth() to kill the dulicated code

2018-07-10 Thread Vinod
On 11-07-18, 00:23, Robin Gong wrote: > Add check_bd_buswidth() to minimize the code size. this looks mostly fine and I think this should be first patch.. > > Signed-off-by: Robin Gong > --- > drivers/dma/imx-sdma.c | 64 > +++--- > 1 file changed,

[PATCH v1 2/4] dmaengine: imx-sdma: add check_bd_buswidth() to kill the dulicated code

2018-07-10 Thread Robin Gong
Add check_bd_buswidth() to minimize the code size. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 64 +++--- 1 file changed, 29 insertions(+), 35 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 27ccabf..ed2267d

[PATCH v1 2/4] dmaengine: imx-sdma: add check_bd_buswidth() to kill the dulicated code

2018-07-10 Thread Robin Gong
Add check_bd_buswidth() to minimize the code size. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 64 +++--- 1 file changed, 29 insertions(+), 35 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 27ccabf..ed2267d