Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 03:51:51PM -0400, Joel Fernandes wrote: > On Tue, Mar 26, 2019 at 08:19:43PM +0100, Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 02:10:12PM -0400, Joel Fernandes wrote: > > > On Tue, Mar 26, 2019 at 06:22:33PM +0100, Christian Brauner wrote: > > > > On Tue, Mar 26,

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Joel Fernandes
On Tue, Mar 26, 2019 at 08:19:43PM +0100, Christian Brauner wrote: > On Tue, Mar 26, 2019 at 02:10:12PM -0400, Joel Fernandes wrote: > > On Tue, Mar 26, 2019 at 06:22:33PM +0100, Christian Brauner wrote: > > > On Tue, Mar 26, 2019 at 01:06:01PM -0400, Joel Fernandes wrote: > > > > On Tue, Mar 26,

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 02:10:12PM -0400, Joel Fernandes wrote: > On Tue, Mar 26, 2019 at 06:22:33PM +0100, Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 01:06:01PM -0400, Joel Fernandes wrote: > > > On Tue, Mar 26, 2019 at 04:55:11PM +0100, Christian Brauner wrote: > > > > The pidctl()

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Joel Fernandes
On Tue, Mar 26, 2019 at 07:19:30PM +0100, Christian Brauner wrote: [snip] > > > > I am actually supportive of Daniel's view that by combining too many > > > > arguments into a single syscall, becomes confusing and sometimes some > > > > arguments have to be forced to 0 in the single shoe-horned

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 02:10:12PM -0400, Joel Fernandes wrote: > On Tue, Mar 26, 2019 at 06:22:33PM +0100, Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 01:06:01PM -0400, Joel Fernandes wrote: > > > On Tue, Mar 26, 2019 at 04:55:11PM +0100, Christian Brauner wrote: > > > > The pidctl()

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Joel Fernandes
On Tue, Mar 26, 2019 at 06:22:33PM +0100, Christian Brauner wrote: > On Tue, Mar 26, 2019 at 01:06:01PM -0400, Joel Fernandes wrote: > > On Tue, Mar 26, 2019 at 04:55:11PM +0100, Christian Brauner wrote: > > > The pidctl() syscalls builds on, extends, and improves translate_pid() > > > [4]. > > >

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 01:06:01PM -0400, Joel Fernandes wrote: > On Tue, Mar 26, 2019 at 04:55:11PM +0100, Christian Brauner wrote: > > The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > > I quote Konstantins original patchset first that has already been acked and > >

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Joel Fernandes
On Tue, Mar 26, 2019 at 1:17 PM Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 01:15:25PM -0400, Joel Fernandes wrote: > > On Tue, Mar 26, 2019 at 06:08:28PM +0100, Christian Brauner wrote: > > [snip] > > > > > > > > > + > > > > > + if (!result) > > > > > +

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 01:15:25PM -0400, Joel Fernandes wrote: > On Tue, Mar 26, 2019 at 06:08:28PM +0100, Christian Brauner wrote: > [snip] > > > > + struct pid *struct_pid; > > > > + pid_t result; > > > > + > > > > + if (flags) > > > > + return -EINVAL; > > > > +

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Joel Fernandes
On Tue, Mar 26, 2019 at 06:08:28PM +0100, Christian Brauner wrote: [snip] > > > + struct pid *struct_pid; > > > + pid_t result; > > > + > > > + if (flags) > > > + return -EINVAL; > > > + > > > + switch (cmd) { > > > + case PIDCMD_QUERY_PID: > > > + break; > > > + case

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 01:06:01PM -0400, Joel Fernandes wrote: > On Tue, Mar 26, 2019 at 04:55:11PM +0100, Christian Brauner wrote: > > The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > > I quote Konstantins original patchset first that has already been acked and > >

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 09:50:28AM -0700, Daniel Colascione wrote: > On Tue, Mar 26, 2019 at 9:44 AM Christian Brauner > wrote: > > > > On Tue, Mar 26, 2019 at 09:38:31AM -0700, Daniel Colascione wrote: > > > On Tue, Mar 26, 2019 at 9:34 AM Christian Brauner > > > wrote: > > > > > > > > On

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Joel Fernandes
On Tue, Mar 26, 2019 at 04:55:11PM +0100, Christian Brauner wrote: > The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > I quote Konstantins original patchset first that has already been acked and > picked up by Eric before and whose functionality is preserved in this >

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Daniel Colascione
On Tue, Mar 26, 2019 at 9:46 AM Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 09:42:59AM -0700, Andy Lutomirski wrote: > > On Tue, Mar 26, 2019 at 9:34 AM Christian Brauner > > wrote: > > > > > > On Tue, Mar 26, 2019 at 05:31:42PM +0100, Christian Brauner wrote: > > > > On Tue, Mar 26,

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Daniel Colascione
On Tue, Mar 26, 2019 at 9:44 AM Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 09:38:31AM -0700, Daniel Colascione wrote: > > On Tue, Mar 26, 2019 at 9:34 AM Christian Brauner > > wrote: > > > > > > On Tue, Mar 26, 2019 at 05:31:42PM +0100, Christian Brauner wrote: > > > > On Tue, Mar 26,

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 09:42:59AM -0700, Andy Lutomirski wrote: > On Tue, Mar 26, 2019 at 9:34 AM Christian Brauner > wrote: > > > > On Tue, Mar 26, 2019 at 05:31:42PM +0100, Christian Brauner wrote: > > > On Tue, Mar 26, 2019 at 05:23:37PM +0100, Christian Brauner wrote: > > > > On Tue, Mar

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 09:38:31AM -0700, Daniel Colascione wrote: > On Tue, Mar 26, 2019 at 9:34 AM Christian Brauner > wrote: > > > > On Tue, Mar 26, 2019 at 05:31:42PM +0100, Christian Brauner wrote: > > > On Tue, Mar 26, 2019 at 05:23:37PM +0100, Christian Brauner wrote: > > > > On Tue, Mar

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Andy Lutomirski
On Tue, Mar 26, 2019 at 9:34 AM Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 05:31:42PM +0100, Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 05:23:37PM +0100, Christian Brauner wrote: > > > On Tue, Mar 26, 2019 at 09:17:07AM -0700, Daniel Colascione wrote: > > > > Thanks for the

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Daniel Colascione
On Tue, Mar 26, 2019 at 9:34 AM Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 05:31:42PM +0100, Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 05:23:37PM +0100, Christian Brauner wrote: > > > On Tue, Mar 26, 2019 at 09:17:07AM -0700, Daniel Colascione wrote: > > > > Thanks for the

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Daniel Colascione
On Tue, Mar 26, 2019 at 9:23 AM Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 09:17:07AM -0700, Daniel Colascione wrote: > > Thanks for the patch. > > > > On Tue, Mar 26, 2019 at 8:55 AM Christian Brauner > > wrote: > > > > > > The pidctl() syscalls builds on, extends, and improves

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 05:31:42PM +0100, Christian Brauner wrote: > On Tue, Mar 26, 2019 at 05:23:37PM +0100, Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 09:17:07AM -0700, Daniel Colascione wrote: > > > Thanks for the patch. > > > > > > On Tue, Mar 26, 2019 at 8:55 AM Christian Brauner

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 05:23:37PM +0100, Christian Brauner wrote: > On Tue, Mar 26, 2019 at 09:17:07AM -0700, Daniel Colascione wrote: > > Thanks for the patch. > > > > On Tue, Mar 26, 2019 at 8:55 AM Christian Brauner > > wrote: > > > > > > The pidctl() syscalls builds on, extends, and

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 09:17:07AM -0700, Daniel Colascione wrote: > Thanks for the patch. > > On Tue, Mar 26, 2019 at 8:55 AM Christian Brauner > wrote: > > > > The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > > I quote Konstantins original patchset first that has

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Daniel Colascione
Thanks for the patch. On Tue, Mar 26, 2019 at 8:55 AM Christian Brauner wrote: > > The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > I quote Konstantins original patchset first that has already been acked and > picked up by Eric before and whose functionality is

[PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. I quote Konstantins original patchset first that has already been acked and picked up by Eric before and whose functionality is preserved in this syscall: "Each process have different pids, one for each pid namespace it