Re: [PATCH v1 2/6] phy: qcom-qmp: Power-on PHY before initialization

2017-08-09 Thread Manu Gautam
On 7/21/2017 4:31 PM, Manu Gautam wrote: > } > @@ -729,19 +771,17 @@ static int qcom_qmp_phy_init(struct phy *phy) > void __iomem *pcs = qphy->pcs; > void __iomem *status; > unsigned int mask, val; > - int ret, i; > + int ret; > > dev_vdbg(qmp->dev,

Re: [PATCH v1 2/6] phy: qcom-qmp: Power-on PHY before initialization

2017-08-09 Thread Manu Gautam
On 7/21/2017 4:31 PM, Manu Gautam wrote: > } > @@ -729,19 +771,17 @@ static int qcom_qmp_phy_init(struct phy *phy) > void __iomem *pcs = qphy->pcs; > void __iomem *status; > unsigned int mask, val; > - int ret, i; > + int ret; > > dev_vdbg(qmp->dev,

[PATCH v1 2/6] phy: qcom-qmp: Power-on PHY before initialization

2017-07-21 Thread Manu Gautam
PHY must be powered on before turning ON clocks and attempting to initialize it. Driver is exposing separate init and power_on routines for this. Apparently USB dwc3 core driver performs power-on after init. Also, poweron and init for QMP PHY need to be executed together always, hence remove

[PATCH v1 2/6] phy: qcom-qmp: Power-on PHY before initialization

2017-07-21 Thread Manu Gautam
PHY must be powered on before turning ON clocks and attempting to initialize it. Driver is exposing separate init and power_on routines for this. Apparently USB dwc3 core driver performs power-on after init. Also, poweron and init for QMP PHY need to be executed together always, hence remove