Re: [PATCH v1 2/7] drm: move DRM_SWITCH_POWER defines to drm_device.h

2018-12-27 Thread Sam Ravnborg
Hi Daniel. > > +/* Used by drm_device.switch_power_state */ > > +#define DRM_SWITCH_POWER_ON 0 > > +#define DRM_SWITCH_POWER_OFF 1 > > +#define DRM_SWITCH_POWER_CHANGING 2 > > +#define DRM_SWITCH_POWER_DYNAMIC_OFF 3 > > Since this isn't uapi it'd be nice to change it to an enum, which we can >

Re: [PATCH v1 2/7] drm: move DRM_SWITCH_POWER defines to drm_device.h

2018-12-27 Thread Daniel Vetter
On Wed, Dec 26, 2018 at 10:03:48PM +0100, Sam Ravnborg wrote: > Move DRM_SWITCH_POWER out of drmP.h to allow users > to get rid of the drmP include. > > DRM_SWITCH_POWER defines are used in combination > with drm_device.switch_power_state. > > Move the DRM_SWITCH_POWER defines to the file where

[PATCH v1 2/7] drm: move DRM_SWITCH_POWER defines to drm_device.h

2018-12-26 Thread Sam Ravnborg
Move DRM_SWITCH_POWER out of drmP.h to allow users to get rid of the drmP include. DRM_SWITCH_POWER defines are used in combination with drm_device.switch_power_state. Move the DRM_SWITCH_POWER defines to the file where drm_device.switch_power_state is defined. Signed-off-by: Sam Ravnborg Cc: