Re: [PATCH v1 3/3] drivers/tty: increase priority for tty_buffer_worker

2019-03-11 Thread Alexander Sverdlin
Hello Oleksij, On Thu, 10 Jan 2019 11:12:32 +0100 Oleksij Rempel wrote: > sched_priority = 1 is enough to dramatically reduce latency > on have system load produced by tasks with default user space prio. > > Signed-off-by: Oleksij Rempel Tested-by: Alexander Sverdlin > --- > drivers/tty/tt

Re: [PATCH v1 3/3] drivers/tty: increase priority for tty_buffer_worker

2019-01-28 Thread Linus Torvalds
On Mon, Jan 28, 2019 at 12:03 PM Linus Torvalds wrote: > > That's harder to do for reads - because incoming characters happen in > interrupt context, but shouldn't be all that hard to do for writes. Side note: the reason I mention this part is that "harder" may not mean "impossible". In particul

Re: [PATCH v1 3/3] drivers/tty: increase priority for tty_buffer_worker

2019-01-28 Thread Linus Torvalds
On Mon, Jan 28, 2019 at 1:22 AM Oleksij Rempel wrote: > > Yes, I tested it with different linux-rt version with mostly similar results: Hmm. It strikes me that you use very carefully timed serial *writes* to control the laser cutter, but the flip buffer handling is mostly a latency issue on the *

Re: [PATCH v1 3/3] drivers/tty: increase priority for tty_buffer_worker

2019-01-28 Thread Oleksij Rempel
On 28.01.19 09:23, Greg Kroah-Hartman wrote: On Mon, Jan 28, 2019 at 09:05:30AM +0100, Oleksij Rempel wrote: On 10.01.19 17:30, Greg Kroah-Hartman wrote: On Thu, Jan 10, 2019 at 04:19:53PM +0100, Oleksij Rempel wrote: My gut feel is that if somebody still cares deeply about serial line la

Re: [PATCH v1 3/3] drivers/tty: increase priority for tty_buffer_worker

2019-01-28 Thread Greg Kroah-Hartman
On Mon, Jan 28, 2019 at 09:05:30AM +0100, Oleksij Rempel wrote: > > > On 10.01.19 17:30, Greg Kroah-Hartman wrote: > > On Thu, Jan 10, 2019 at 04:19:53PM +0100, Oleksij Rempel wrote: > > > > My gut feel is that if somebody still cares deeply about serial line > > > > latency, they should look at

Re: [PATCH v1 3/3] drivers/tty: increase priority for tty_buffer_worker

2019-01-28 Thread Oleksij Rempel
On 10.01.19 17:30, Greg Kroah-Hartman wrote: On Thu, Jan 10, 2019 at 04:19:53PM +0100, Oleksij Rempel wrote: My gut feel is that if somebody still cares deeply about serial line latency, they should look at trying to see if they can do some of the work directly without the bounce to the workq

Re: [PATCH v1 3/3] drivers/tty: increase priority for tty_buffer_worker

2019-01-10 Thread Linus Torvalds
On Thu, Jan 10, 2019 at 7:19 AM Oleksij Rempel wrote: > > It is for industrial low latency RS-422 based application. The loopback > test is just easy way to test/reproduce it without additional hardware. > > What is good, mainlineable way to implement it? I can easily see that for that specific u

Re: [PATCH v1 3/3] drivers/tty: increase priority for tty_buffer_worker

2019-01-10 Thread Greg Kroah-Hartman
On Thu, Jan 10, 2019 at 04:19:53PM +0100, Oleksij Rempel wrote: > > My gut feel is that if somebody still cares deeply about serial line > > latency, they should look at trying to see if they can do some of the > > work directly without the bounce to the workqueue. We use workqueues > > for a reaso

Re: [PATCH v1 3/3] drivers/tty: increase priority for tty_buffer_worker

2019-01-10 Thread Oleksij Rempel
On Thu, Jan 10, 2019 at 04:54:53AM -0800, Linus Torvalds wrote: > On Thu, Jan 10, 2019 at 2:12 AM Oleksij Rempel > wrote: > > > > sched_priority = 1 is enough to dramatically reduce latency > > on have system load produced by tasks with default user space prio. > > .. and is this perhaps a way f

Re: [PATCH v1 3/3] drivers/tty: increase priority for tty_buffer_worker

2019-01-10 Thread Linus Torvalds
On Thu, Jan 10, 2019 at 2:12 AM Oleksij Rempel wrote: > > sched_priority = 1 is enough to dramatically reduce latency > on have system load produced by tasks with default user space prio. .. and is this perhaps a way for a user to then make the system spend inordinate amounts of time in the tty l

[PATCH v1 3/3] drivers/tty: increase priority for tty_buffer_worker

2019-01-10 Thread Oleksij Rempel
sched_priority = 1 is enough to dramatically reduce latency on have system load produced by tasks with default user space prio. Signed-off-by: Oleksij Rempel --- drivers/tty/tty_buffer.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/tty/tty_buffer.c b/d