Re: [PATCH v1 3/3] skd: use generic power management

2020-07-21 Thread Vaibhav Gupta
On Tue, Jul 21, 2020 at 02:49:06AM +, Damien Le Moal wrote: > On 2020/07/20 22:18, Vaibhav Gupta wrote: > > On Mon, Jul 20, 2020 at 12:52:14PM +, Damien Le Moal wrote: > >> On 2020/07/17 17:10, Vaibhav Gupta wrote: > >>> Change function parameter in both .suspend() and .resume() to > >>> "s

Re: [PATCH v1 3/3] skd: use generic power management

2020-07-20 Thread Damien Le Moal
On 2020/07/20 22:18, Vaibhav Gupta wrote: > On Mon, Jul 20, 2020 at 12:52:14PM +, Damien Le Moal wrote: >> On 2020/07/17 17:10, Vaibhav Gupta wrote: >>> Drivers using legacy PM have to manage PCI states and device's PM states >>> themselves. They also need to take care of configuration register

Re: [PATCH v1 3/3] skd: use generic power management

2020-07-20 Thread Vaibhav Gupta
On Mon, Jul 20, 2020 at 12:52:14PM +, Damien Le Moal wrote: > On 2020/07/17 17:10, Vaibhav Gupta wrote: > > Drivers using legacy PM have to manage PCI states and device's PM states > > themselves. They also need to take care of configuration registers. > > > > With improved and powerful suppor

Re: [PATCH v1 3/3] skd: use generic power management

2020-07-20 Thread Damien Le Moal
On 2020/07/17 17:10, Vaibhav Gupta wrote: > Drivers using legacy PM have to manage PCI states and device's PM states > themselves. They also need to take care of configuration registers. > > With improved and powerful support of generic PM, PCI Core takes care of > above mentioned, device-independ

[PATCH v1 3/3] skd: use generic power management

2020-07-17 Thread Vaibhav Gupta
Drivers using legacy PM have to manage PCI states and device's PM states themselves. They also need to take care of configuration registers. With improved and powerful support of generic PM, PCI Core takes care of above mentioned, device-independent, jobs. This driver makes use of PCI helper func