RE: [PATCH v1 3/3] usb: gadget: NCM: Stop RX TCP Bursts getting dropped.

2014-06-12 Thread David Laight
From: Jim Baxter > On 30/05/14 12:25, Jim Baxter wrote: > > On 29/05/14 20:04, Eric Dumazet wrote: > >> On Thu, 2014-05-29 at 18:12 +0100, Jim Baxter wrote: > >> > >> Note the patch is OK, but changelog a bit misleading ;) > >> > >> Kernel was not running out of memory, because truesize was correct

Re: [PATCH v1 3/3] usb: gadget: NCM: Stop RX TCP Bursts getting dropped.

2014-06-12 Thread Jim Baxter
On 30/05/14 12:25, Jim Baxter wrote: > On 29/05/14 20:04, Eric Dumazet wrote: >> On Thu, 2014-05-29 at 18:12 +0100, Jim Baxter wrote: >> >> Note the patch is OK, but changelog a bit misleading ;) >> >> Kernel was not running out of memory, because truesize was correct. >> >> The problem here is tha

Re: [PATCH v1 3/3] usb: gadget: NCM: Stop RX TCP Bursts getting dropped.

2014-05-30 Thread Jim Baxter
On 29/05/14 20:04, Eric Dumazet wrote: > On Thu, 2014-05-29 at 18:12 +0100, Jim Baxter wrote: >> This fixes a problem with dropped packets over 16k CDC-NCM >> when the connection is being heavily used. >> >> The issue was that the skb truesize for the unpacked NCM >> packets was too high after they

Re: [PATCH v1 3/3] usb: gadget: NCM: Stop RX TCP Bursts getting dropped.

2014-05-29 Thread Eric Dumazet
On Thu, 2014-05-29 at 18:12 +0100, Jim Baxter wrote: > This fixes a problem with dropped packets over 16k CDC-NCM > when the connection is being heavily used. > > The issue was that the skb truesize for the unpacked NCM > packets was too high after they were cloned from the 16k > skb, this lead to

[PATCH v1 3/3] usb: gadget: NCM: Stop RX TCP Bursts getting dropped.

2014-05-29 Thread Jim Baxter
This fixes a problem with dropped packets over 16k CDC-NCM when the connection is being heavily used. The issue was that the skb truesize for the unpacked NCM packets was too high after they were cloned from the 16k skb, this lead to the potential memory calculated by the Kernel running out of mem