Re: [PATCH v1 3/4] ARM: dts: add pwm pins for r40.

2018-01-15 Thread Maxime Ripard
On Sun, Jan 14, 2018 at 03:07:46PM +0800, Hao Zhang wrote: > 2018-01-11 20:47 GMT+08:00 Maxime Ripard : > > Hi, > > > > On Thu, Jan 11, 2018 at 07:33:23PM +0800, hao_zhang wrote: > >> This patch add pwm pins for r40. > >> > >> Signed-off-by: hao_zhang > > > > You should order your patches differen

Re: [PATCH v1 3/4] ARM: dts: add pwm pins for r40.

2018-01-13 Thread Hao Zhang
2018-01-11 20:47 GMT+08:00 Maxime Ripard : > Hi, > > On Thu, Jan 11, 2018 at 07:33:23PM +0800, hao_zhang wrote: >> This patch add pwm pins for r40. >> >> Signed-off-by: hao_zhang > > You should order your patches differently. We try to be as bisectable > as possible, and if we just apply this patc

Re: [PATCH v1 3/4] ARM: dts: add pwm pins for r40.

2018-01-11 Thread Maxime Ripard
Hi, On Thu, Jan 11, 2018 at 07:33:23PM +0800, hao_zhang wrote: > This patch add pwm pins for r40. > > Signed-off-by: hao_zhang You should order your patches differently. We try to be as bisectable as possible, and if we just apply this patch the DT will not compile anymore. Your patch 4 should

[PATCH v1 3/4] ARM: dts: add pwm pins for r40.

2018-01-11 Thread hao_zhang
This patch add pwm pins for r40. Signed-off-by: hao_zhang --- arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts index 8c5efe2..6cf6273