Re: [PATCH v1 4/4] pci: Re-use new dmi_get_bios_year() helper

2018-02-28 Thread Bjorn Helgaas
On Wed, Feb 28, 2018 at 12:12:22PM +0200, Andy Shevchenko wrote: > On Mon, 2018-02-26 at 12:19 -0600, Bjorn Helgaas wrote: > > On Sun, Feb 25, 2018 at 03:27:04PM +0200, Andy Shevchenko wrote: > > > On Fri, 2018-02-23 at 15:40 -0600, Bjorn Helgaas wrote: > > > > On Thu, Feb 22, 2018 at 02:59:23PM +0

Re: [PATCH v1 4/4] pci: Re-use new dmi_get_bios_year() helper

2018-02-28 Thread Andy Shevchenko
On Mon, 2018-02-26 at 12:19 -0600, Bjorn Helgaas wrote: > On Sun, Feb 25, 2018 at 03:27:04PM +0200, Andy Shevchenko wrote: > > On Fri, 2018-02-23 at 15:40 -0600, Bjorn Helgaas wrote: > > > On Thu, Feb 22, 2018 at 02:59:23PM +0200, Andy Shevchenko wrote: > > > > ...instead of open coding its functio

Re: [PATCH v1 4/4] pci: Re-use new dmi_get_bios_year() helper

2018-02-26 Thread Jean Delvare
On Thu, 22 Feb 2018 14:59:23 +0200, Andy Shevchenko wrote: > ...instead of open coding its functionality. > > Signed-off-by: Andy Shevchenko > --- > drivers/pci/pci.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index f6a4

Re: [PATCH v1 4/4] pci: Re-use new dmi_get_bios_year() helper

2018-02-26 Thread Bjorn Helgaas
On Sun, Feb 25, 2018 at 03:27:04PM +0200, Andy Shevchenko wrote: > On Fri, 2018-02-23 at 15:40 -0600, Bjorn Helgaas wrote: > > On Thu, Feb 22, 2018 at 02:59:23PM +0200, Andy Shevchenko wrote: > > > ...instead of open coding its functionality. > > > > Same comment about making the changelog complet

Re: [PATCH v1 4/4] pci: Re-use new dmi_get_bios_year() helper

2018-02-25 Thread Andy Shevchenko
On Fri, 2018-02-23 at 15:40 -0600, Bjorn Helgaas wrote: > Please use > > PCI: Re-use ... > > to match the prevailing drivers/pci style. Noted. (Same for x86/PCI part) > On Thu, Feb 22, 2018 at 02:59:23PM +0200, Andy Shevchenko wrote: > > ...instead of open coding its functionality. > > Same

Re: [PATCH v1 4/4] pci: Re-use new dmi_get_bios_year() helper

2018-02-23 Thread Bjorn Helgaas
Please use PCI: Re-use ... to match the prevailing drivers/pci style. On Thu, Feb 22, 2018 at 02:59:23PM +0200, Andy Shevchenko wrote: > ...instead of open coding its functionality. Same comment about making the changelog complete, independent of the subject. > Signed-off-by: Andy Shevchenko

[PATCH v1 4/4] pci: Re-use new dmi_get_bios_year() helper

2018-02-22 Thread Andy Shevchenko
...instead of open coding its functionality. Signed-off-by: Andy Shevchenko --- drivers/pci/pci.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index f6a4dd10d9b0..ae654e21439d 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c