Re: [PATCH v1 5/6] KEYS: measure queued keys

2019-10-23 Thread Mimi Zohar
On Wed, 2019-10-23 at 13:52 -0400, Mimi Zohar wrote: > On Wed, 2019-10-23 at 10:34 -0700, Lakshmi Ramasubramanian wrote: > > On 10/23/19 6:23 AM, Mimi Zohar wrote: > > > > > The ordering of this patch set is awkward.  It should first introduce > > > a generic method for measuring keys based on the

Re: [PATCH v1 5/6] KEYS: measure queued keys

2019-10-23 Thread Mimi Zohar
On Wed, 2019-10-23 at 10:34 -0700, Lakshmi Ramasubramanian wrote: > On 10/23/19 6:23 AM, Mimi Zohar wrote: > > > The ordering of this patch set is awkward.  It should first introduce > > a generic method for measuring keys based on the keyring.  Then add > > the additional support needed for the s

Re: [PATCH v1 5/6] KEYS: measure queued keys

2019-10-23 Thread Lakshmi Ramasubramanian
On 10/23/19 6:23 AM, Mimi Zohar wrote: The ordering of this patch set is awkward.  It should first introduce a generic method for measuring keys based on the keyring.  Then add the additional support needed for the specific builtin_trusted_keys keyring usecase. Would the following ordering of

Re: [PATCH v1 5/6] KEYS: measure queued keys

2019-10-23 Thread Mimi Zohar
On Tue, 2019-10-22 at 17:18 -0700, Lakshmi Ramasubramanian wrote: > Call process_buffer_measurement to measure keys that > are added and updated in the system. This patch description doesn't describe what the patch actually does (eg. it not only calls process_buffer_measurement, but defines the IM

[PATCH v1 5/6] KEYS: measure queued keys

2019-10-22 Thread Lakshmi Ramasubramanian
Call process_buffer_measurement to measure keys that are added and updated in the system. Signed-off-by: Lakshmi Ramasubramanian --- security/integrity/ima/ima_main.c | 23 + security/integrity/ima/ima_queue.c | 32 ++ 2 files changed, 55 insertio