Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-05-10 Thread Sean Wang
On Tue, 2018-05-08 at 13:18 +0200, Marcel Holtmann wrote: > Hi Sean, > > > + [ ... ] > > > > I'm happy to do with btmon. just the environment with buildroot the BT > > running on seems there's a missing support for btmon. I can start to use > > btmon once I change the environment to

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-05-10 Thread Sean Wang
On Tue, 2018-05-08 at 13:18 +0200, Marcel Holtmann wrote: > Hi Sean, > > > + [ ... ] > > > > I'm happy to do with btmon. just the environment with buildroot the BT > > running on seems there's a missing support for btmon. I can start to use > > btmon once I change the environment to

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-05-08 Thread Marcel Holtmann
Hi Sean, > + > +static int mtk_wmt_cmd_sync(struct hci_uart *hu, u8 opcode, u8 flag, u16 > plen, > + const void *param) > +{ > + struct mtk_bt_dev *btdev = hu->priv; > + struct hci_command_hdr *hhdr; > + struct hci_acl_hdr *ahdr; > + struct

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-05-08 Thread Marcel Holtmann
Hi Sean, > + > +static int mtk_wmt_cmd_sync(struct hci_uart *hu, u8 opcode, u8 flag, u16 > plen, > + const void *param) > +{ > + struct mtk_bt_dev *btdev = hu->priv; > + struct hci_command_hdr *hhdr; > + struct hci_acl_hdr *ahdr; > + struct

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-05-08 Thread Sean Wang
Hi, Marcel On Tue, 2018-05-08 at 09:27 +0200, Marcel Holtmann wrote: > Hi Sean, > > >>> + > >>> +static int mtk_wmt_cmd_sync(struct hci_uart *hu, u8 opcode, u8 flag, u16 > >>> plen, > >>> + const void *param) > >>> +{ > >>> + struct mtk_bt_dev *btdev = hu->priv; > >>> +

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-05-08 Thread Sean Wang
Hi, Marcel On Tue, 2018-05-08 at 09:27 +0200, Marcel Holtmann wrote: > Hi Sean, > > >>> + > >>> +static int mtk_wmt_cmd_sync(struct hci_uart *hu, u8 opcode, u8 flag, u16 > >>> plen, > >>> + const void *param) > >>> +{ > >>> + struct mtk_bt_dev *btdev = hu->priv; > >>> +

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-05-08 Thread Marcel Holtmann
Hi Sean, >>> + >>> +static int mtk_wmt_cmd_sync(struct hci_uart *hu, u8 opcode, u8 flag, u16 >>> plen, >>> + const void *param) >>> +{ >>> + struct mtk_bt_dev *btdev = hu->priv; >>> + struct hci_command_hdr *hhdr; >>> + struct hci_acl_hdr *ahdr; >>> + struct

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-05-08 Thread Marcel Holtmann
Hi Sean, >>> + >>> +static int mtk_wmt_cmd_sync(struct hci_uart *hu, u8 opcode, u8 flag, u16 >>> plen, >>> + const void *param) >>> +{ >>> + struct mtk_bt_dev *btdev = hu->priv; >>> + struct hci_command_hdr *hhdr; >>> + struct hci_acl_hdr *ahdr; >>> + struct

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-05-08 Thread Sean Wang
Hi, Marcel On Tue, 2018-04-03 at 12:27 +0200, Marcel Holtmann wrote: > Hi Sean, > [ ... ] > > + > > +static int mtk_wmt_cmd_sync(struct hci_uart *hu, u8 opcode, u8 flag, u16 > > plen, > > + const void *param) > > +{ > > + struct mtk_bt_dev *btdev = hu->priv; > > +

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-05-08 Thread Sean Wang
Hi, Marcel On Tue, 2018-04-03 at 12:27 +0200, Marcel Holtmann wrote: > Hi Sean, > [ ... ] > > + > > +static int mtk_wmt_cmd_sync(struct hci_uart *hu, u8 opcode, u8 flag, u16 > > plen, > > + const void *param) > > +{ > > + struct mtk_bt_dev *btdev = hu->priv; > > +

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-27 Thread Marcel Holtmann
Hi Sean, >>> This adds a driver for the MediaTek serial protocol based on H4 >>> protocol, >>> which can enable the built-in Bluetooth device inside MT7622 SoC. >>> >>> Signed-off-by: Sean Wang >>> --- >>> > > [... snip ...] > >>> >>> where

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-27 Thread Marcel Holtmann
Hi Sean, >>> This adds a driver for the MediaTek serial protocol based on H4 >>> protocol, >>> which can enable the built-in Bluetooth device inside MT7622 SoC. >>> >>> Signed-off-by: Sean Wang >>> --- >>> > > [... snip ...] > >>> >>> where could I find the newest

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-27 Thread Sean Wang
On Fri, 2018-04-27 at 07:25 +0200, Marcel Holtmann wrote: > Hi Sean, > > > This adds a driver for the MediaTek serial protocol based on H4 > > protocol, > > which can enable the built-in Bluetooth device inside MT7622 SoC. > > > > Signed-off-by: Sean Wang

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-27 Thread Sean Wang
On Fri, 2018-04-27 at 07:25 +0200, Marcel Holtmann wrote: > Hi Sean, > > > This adds a driver for the MediaTek serial protocol based on H4 > > protocol, > > which can enable the built-in Bluetooth device inside MT7622 SoC. > > > > Signed-off-by: Sean Wang > > --- > >

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-26 Thread Marcel Holtmann
Hi Sean, > This adds a driver for the MediaTek serial protocol based on H4 protocol, > which can enable the built-in Bluetooth device inside MT7622 SoC. > > Signed-off-by: Sean Wang > --- > > [... snip ...] > > + > + /* Start to build a WMT

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-26 Thread Marcel Holtmann
Hi Sean, > This adds a driver for the MediaTek serial protocol based on H4 protocol, > which can enable the built-in Bluetooth device inside MT7622 SoC. > > Signed-off-by: Sean Wang > --- > > [... snip ...] > > + > + /* Start to build a WMT header and its actual

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-26 Thread Sean Wang
On Thu, 2018-04-26 at 11:47 +0200, Marcel Holtmann wrote: > Hi Sean, > > >>> This adds a driver for the MediaTek serial protocol based on H4 protocol, > >>> which can enable the built-in Bluetooth device inside MT7622 SoC. > >>> > >>> Signed-off-by: Sean Wang > >>> ---

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-26 Thread Sean Wang
On Thu, 2018-04-26 at 11:47 +0200, Marcel Holtmann wrote: > Hi Sean, > > >>> This adds a driver for the MediaTek serial protocol based on H4 protocol, > >>> which can enable the built-in Bluetooth device inside MT7622 SoC. > >>> > >>> Signed-off-by: Sean Wang > >>> --- [... snip ...] > >>> +

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-26 Thread Marcel Holtmann
Hi Sean, >>> This adds a driver for the MediaTek serial protocol based on H4 protocol, >>> which can enable the built-in Bluetooth device inside MT7622 SoC. >>> >>> Signed-off-by: Sean Wang >>> --- >>> drivers/bluetooth/Kconfig| 12 + >>>

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-26 Thread Marcel Holtmann
Hi Sean, >>> This adds a driver for the MediaTek serial protocol based on H4 protocol, >>> which can enable the built-in Bluetooth device inside MT7622 SoC. >>> >>> Signed-off-by: Sean Wang >>> --- >>> drivers/bluetooth/Kconfig| 12 + >>> drivers/bluetooth/Makefile | 1 + >>>

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-26 Thread Sean Wang
On Tue, 2018-04-03 at 12:27 +0200, Marcel Holtmann wrote: > Hi Sean, > > > This adds a driver for the MediaTek serial protocol based on H4 protocol, > > which can enable the built-in Bluetooth device inside MT7622 SoC. > > > > Signed-off-by: Sean Wang > > --- > >

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-26 Thread Sean Wang
On Tue, 2018-04-03 at 12:27 +0200, Marcel Holtmann wrote: > Hi Sean, > > > This adds a driver for the MediaTek serial protocol based on H4 protocol, > > which can enable the built-in Bluetooth device inside MT7622 SoC. > > > > Signed-off-by: Sean Wang > > --- > > drivers/bluetooth/Kconfig

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-03 Thread kbuild test robot
Hi Sean, I love your patch! Perhaps something to improve: [auto build test WARNING on next-20180329] [also build test WARNING on v4.16] [cannot apply to linus/master bluetooth/master bluetooth-next/master v4.16 v4.16-rc7 v4.16-rc6] [if your patch is applied to the wrong git tree, please drop us

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-03 Thread kbuild test robot
Hi Sean, I love your patch! Perhaps something to improve: [auto build test WARNING on next-20180329] [also build test WARNING on v4.16] [cannot apply to linus/master bluetooth/master bluetooth-next/master v4.16 v4.16-rc7 v4.16-rc6] [if your patch is applied to the wrong git tree, please drop us

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-03 Thread Marcel Holtmann
Hi Sean, > This adds a driver for the MediaTek serial protocol based on H4 protocol, > which can enable the built-in Bluetooth device inside MT7622 SoC. > > Signed-off-by: Sean Wang > --- > drivers/bluetooth/Kconfig| 12 + > drivers/bluetooth/Makefile | 1

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-03 Thread Marcel Holtmann
Hi Sean, > This adds a driver for the MediaTek serial protocol based on H4 protocol, > which can enable the built-in Bluetooth device inside MT7622 SoC. > > Signed-off-by: Sean Wang > --- > drivers/bluetooth/Kconfig| 12 + > drivers/bluetooth/Makefile | 1 + >

[PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-03 Thread sean.wang
From: Sean Wang This adds a driver for the MediaTek serial protocol based on H4 protocol, which can enable the built-in Bluetooth device inside MT7622 SoC. Signed-off-by: Sean Wang --- drivers/bluetooth/Kconfig| 12 +

[PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-04-03 Thread sean.wang
From: Sean Wang This adds a driver for the MediaTek serial protocol based on H4 protocol, which can enable the built-in Bluetooth device inside MT7622 SoC. Signed-off-by: Sean Wang --- drivers/bluetooth/Kconfig| 12 + drivers/bluetooth/Makefile | 1 +