Re: [PATCH v1 7/8] perf c2c: Add option '-d llc' for sorting with LLC load

2020-10-22 Thread Jiri Olsa
On Tue, Oct 20, 2020 at 04:08:39PM +0800, Leo Yan wrote: SNIP > > > > please update man page with this > > > > > else { > > > pr_err("failed: unknown display type: %s\n", str); > > > return -1; > > > @@ -2766,9 +2795,10 @@ static int build_cl_output(char *cl_sort, bool >

Re: [PATCH v1 7/8] perf c2c: Add option '-d llc' for sorting with LLC load

2020-10-20 Thread Leo Yan
On Tue, Oct 20, 2020 at 09:26:03AM +0200, Jiri Olsa wrote: > On Thu, Oct 15, 2020 at 03:50:40PM +0100, Leo Yan wrote: > > Except the existed three display options 'tot', 'rmt', 'lcl', this patch > > adds option 'llc' so that can sort on LLC load metrics. The new > > introduced option can work as a

Re: [PATCH v1 7/8] perf c2c: Add option '-d llc' for sorting with LLC load

2020-10-20 Thread Leo Yan
Hi Jiri, On Tue, Oct 20, 2020 at 09:25:53AM +0200, Jiri Olsa wrote: > On Thu, Oct 15, 2020 at 03:50:40PM +0100, Leo Yan wrote: > > SNIP > > > @@ -1533,6 +1539,7 @@ static struct c2c_header percent_hitm_header[] = { > > [DISPLAY_LCL] = HEADER_BOTH("Lcl", "Hitm"), > > [DISPLAY_RMT] = HEADE

Re: [PATCH v1 7/8] perf c2c: Add option '-d llc' for sorting with LLC load

2020-10-20 Thread Jiri Olsa
On Thu, Oct 15, 2020 at 03:50:40PM +0100, Leo Yan wrote: > Except the existed three display options 'tot', 'rmt', 'lcl', this patch > adds option 'llc' so that can sort on LLC load metrics. The new > introduced option can work as a choice if the memory event doesn't > contain HITM tags. > > For t

Re: [PATCH v1 7/8] perf c2c: Add option '-d llc' for sorting with LLC load

2020-10-20 Thread Jiri Olsa
On Thu, Oct 15, 2020 at 03:50:40PM +0100, Leo Yan wrote: SNIP > @@ -1533,6 +1539,7 @@ static struct c2c_header percent_hitm_header[] = { > [DISPLAY_LCL] = HEADER_BOTH("Lcl", "Hitm"), > [DISPLAY_RMT] = HEADER_BOTH("Rmt", "Hitm"), > [DISPLAY_TOT] = HEADER_BOTH("Tot", "Hitm"), > +

[PATCH v1 7/8] perf c2c: Add option '-d llc' for sorting with LLC load

2020-10-15 Thread Leo Yan
Except the existed three display options 'tot', 'rmt', 'lcl', this patch adds option 'llc' so that can sort on LLC load metrics. The new introduced option can work as a choice if the memory event doesn't contain HITM tags. For the display with option 'llc', both the "Shared Data Cache Line Table"