Re: [PATCH v1 RESEND 2/2] x86/efi: Clean up a minor mistake in code comment

2017-03-24 Thread Baoquan He
On 03/24/17 at 08:57am, Ard Biesheuvel wrote: > On 23 March 2017 at 03:27, Baoquan He wrote: > > EFI allocate runtime services regions from EFI_VA_START, -4G, down > > to -64G, EFI_VA_END. > > OK, so is the size of the region 60 GB or 64 GB? This suggests 60 GB, > but the comment you update sugge

Re: [PATCH v1 RESEND 2/2] x86/efi: Clean up a minor mistake in code comment

2017-03-24 Thread Ard Biesheuvel
On 23 March 2017 at 03:27, Baoquan He wrote: > EFI allocate runtime services regions from EFI_VA_START, -4G, down > to -64G, EFI_VA_END. OK, so is the size of the region 60 GB or 64 GB? This suggests 60 GB, but the comment you update suggests 64 GB. > The mechanism was introduced in > commit d2f

[PATCH v1 RESEND 2/2] x86/efi: Clean up a minor mistake in code comment

2017-03-22 Thread Baoquan He
EFI allocate runtime services regions from EFI_VA_START, -4G, down to -64G, EFI_VA_END. The mechanism was introduced in commit d2f7cbe7b26a7 ("x86/efi: Runtime services virtual mapping"). Clean it up to avoid confusion. Signed-off-by: Baoquan He Cc: Matt Fleming Cc: Ard Biesheuvel Cc: Thomas G