Re: [PATCH v1.0 14/16] arcmsr: fix sparse checking error

2014-05-05 Thread Dan Carpenter
On Mon, May 05, 2014 at 12:10:39PM +0800, 黃清隆 wrote: > Hi Dan, > > In this patch, there are several replace of call readl() or writel() > by direct access to memory. > Because in main memory, we allocated a block of memory for > post_qbuffer and done_qbuffer. > These memory are access by both of C

Re: [PATCH v1.0 14/16] arcmsr: fix sparse checking error

2014-05-04 Thread 黃清隆
Hi Dan, In this patch, there are several replace of call readl() or writel() by direct access to memory. Because in main memory, we allocated a block of memory for post_qbuffer and done_qbuffer. These memory are access by both of CPU and IOP, they are not hardware registers. This change will not i

Re: [PATCH v1.0 14/16] arcmsr: fix sparse checking error

2014-05-02 Thread Dan Carpenter
On Wed, Apr 30, 2014 at 07:38:26PM +0800, ching wrote: > From: Ching > > Fix sparse utility checking errors. > I was expecting that this patch would add __iomem annotations throughout but in several places it actually removes calls to readl() and writel() as well. > case ACB_ADAPTER_TYPE_

[PATCH v1.0 14/16] arcmsr: fix sparse checking error

2014-04-30 Thread ching
From: Ching Fix sparse utility checking errors. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-04-30 15:22:22.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-04-30 15:22:26.00